Page MenuHomePhabricator

logging: move checkpoint log into VALIDATION debug category
ClosedPublic

Authored by PiRK on Sep 22 2022, 08:51.

Details

Summary

Checkpoint mismatch log messages are very common because of Bitcoin Cash and Bitcoin SV peers, and the word "ERROR" showing up just after starting a node confuses users.

Move these messages to a debug category.

Depends on D12043

Test Plan

ninja all check-all

Start bitcoind and verify for a few minutes that the error messages are no longer printed.

Run bitcoind -debug=VALIDATION and check that the error messages are logged.

Event Timeline

PiRK requested review of this revision.Sep 22 2022, 08:51
PiRK planned changes to this revision.Sep 22 2022, 10:05

This is partially covered by core#23235, so let's backport this (and all dependencies) first, then rebase to apply only the remaining changes

PiRK retitled this revision from logging: deduplicate checkpoint mismatch error messages and move them to BCLog::VALIDATION category to logging: move checkpoint log into VALIDATION debug category.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

rebase on top of D12043. Now this diff only moves two messages to the VALIDATION debug category.

This revision is now accepted and ready to land.Sep 23 2022, 08:28
This revision was landed with ongoing or failed builds.Sep 23 2022, 08:49
This revision was automatically updated to reflect the committed changes.