[Cashtab] Fix Reply button not showing
AbandonedPublic
Actions

Authored by kieran709 on Oct 6 2022, 14:33.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Related to T2712. Fixed issue with reply button not showing up, default behavior is now to show reply button on any OPReturnMsg tx.

Test Plan

cd web/cashtab && npm start
Ensure there are msg txs in recent TxHistory
Observe that the reply button is present on all msg txs
Navigate to settings page
Turn on hideMessagesFromUnknownSenders
navigate back to Home
Observe that the reply button is present on all msg txs.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

reply-button-not-showing-up

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20382
Build 40437: Build Diff	cashtab-tests
Build 40436: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 6 2022, 14:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2022, 14:33

kieran709 requested review of this revision.Oct 6 2022, 14:33

Harbormaster completed remote builds in B20382: Diff 35497.Oct 6 2022, 14:36

Changed logic so that if hideMessagesFromUnkownSenders is on, the reply button will only appear on messages from non-contacts that have been expanded, and messages from contacts will display the reply button.

Harbormaster completed remote builds in B20383: Diff 35498.Oct 6 2022, 14:40

Need to implement this on latest master, might be easier to restart vs patch the conflicts as tx.js was changed extensively by chronik implementation in tx history

This revision now requires changes to proceed.Oct 6 2022, 15:10

kieran709 abandoned this revision.Oct 6 2022, 15:16

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

Tx.js

11 lines

Diff 35497

View Options

web/cashtab/src/components/Home/Tx.js

[Cashtab] Fix Reply button not showingAbandonedPublicActions