Differential D12177
[avalanche] Avoid connecting via addavalanchenode in tests Authored by Fabien on Oct 7 2022, 15:36.
Details
This splits the get_ava_p2p_interface in 2 flavors: with or without handshake. This allows for using the natural peer discovery for connecting the avalanche peers in tests rather than requiring to manual connection via addavalanchenode. The tests that can benefit from a noban whitelist to speed up the tests gets updated as well. Depends on D12176. ninja check-functional-extended
Diff Detail
Event Timeline
Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tail of the build log: [0m[0;32mwallet_importprunedfunds.py | ✓ Passed | 2 s [0m[0;32mwallet_importprunedfunds.py --descriptors | ✓ Passed | 3 s [0m[0;32mwallet_keypool.py | ✓ Passed | 3 s [0m[0;32mwallet_keypool_topup.py | ✓ Passed | 4 s [0m[0;32mwallet_keypool_topup.py --descriptors | ✓ Passed | 4 s [0m[0;32mwallet_labels.py | ✓ Passed | 2 s [0m[0;32mwallet_labels.py --descriptors | ✓ Passed | 2 s [0m[0;32mwallet_listreceivedby.py | ✓ Passed | 8 s [0m[0;32mwallet_listsinceblock.py | ✓ Passed | 6 s [0m[0;32mwallet_listsinceblock.py --descriptors | ✓ Passed | 8 s [0m[0;32mwallet_listtransactions.py | ✓ Passed | 4 s [0m[0;32mwallet_listtransactions.py --descriptors | ✓ Passed | 4 s [0m[0;32mwallet_multiwallet.py | ✓ Passed | 48 s [0m[0;32mwallet_multiwallet.py --usecli | ✓ Passed | 16 s [0m[0;32mwallet_reorgsrestore.py | ✓ Passed | 5 s [0m[0;32mwallet_resendwallettransactions.py | ✓ Passed | 3 s [0m[0;32mwallet_send.py | ✓ Passed | 10 s [0m[0;32mwallet_startup.py | ✓ Passed | 4 s [0m[0;32mwallet_txn_clone.py | ✓ Passed | 3 s [0m[0;32mwallet_txn_clone.py --mineblock | ✓ Passed | 4 s [0m[0;32mwallet_txn_doublespend.py | ✓ Passed | 3 s [0m[0;32mwallet_txn_doublespend.py --mineblock | ✓ Passed | 4 s [0m[0;32mwallet_watchonly.py | ✓ Passed | 1 s [0m[0;32mwallet_watchonly.py --usecli | ✓ Passed | 2 s [0m[1m ALL | ✓ Passed | 1786 s (accumulated) [0mRuntime: 358 s [206/478] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.005s OK [208/478] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.001s OK [212/478] Running seeder test suite PASSED: seeder test suite [261/478] bitcoin: testing validationinterface_tests FAILED: src/test/CMakeFiles/check-bitcoin-validationinterface_tests cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-validationinterface_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=validationinterface_tests --logger=HRF,message:JUNIT,message,bitcoin-validationinterface_tests.xml --catch_system_errors=no Running 3 test cases... ../../src/test/validationinterface_tests.cpp(108): error: in "validationinterface_tests/unregister_all_during_call": check destroyed has failed *** 1 failure is detected in the test module "Bitcoin ABC unit tests" [447/478] Running avalanche test suite PASSED: avalanche test suite [450/478] Running pow test suite PASSED: pow test suite [459/478] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [463/478] Running secp256k1 test suite PASSED: secp256k1 test suite [475/478] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1 | |||||||||||||||||||||||||||||