Page MenuHomePhabricator

[avalanche] Fix tests flakiness with manual connections
ClosedPublic

Authored by Fabien on Oct 12 2022, 09:03.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCbd10cc7435b7: [avalanche] Fix tests flakiness with manual connections
Summary

On slow machines the node can see the connection to the test framework peers before the python network thread is marked as connected, causing the test to fail.

This diff fixes it byt waiting for the connection to be marked as established on the python side.

Fixes https://build.bitcoinabc.org/viewLog.html?buildId=447123&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterWOWallet&tab=buildLog and
https://build.bitcoinabc.org/viewLog.html?buildId=449892&buildTypeId=BitcoinABC_Master_CrossBuilds_CrossBuildLinux32&tab=buildLog

Test Plan
./test/functional/test_runner.py abc_p2p_compactproofs abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_getavaaddr_isconnected
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20448
Build 40568: Build Diffbuild-without-wallet · build-diff · build-clang · build-clang-tidy · build-debug
Build 40567: arc lint + arc unit