Page MenuHomePhabricator

[refactor] Add deploymentstatus.h
ClosedPublic

Authored by PiRK on Oct 12 2022, 12:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd35c44c7a03a: [refactor] Add deploymentstatus.h
Summary

Provides DeploymentEnabled, DeploymentActiveAt, and DeploymentActiveAfter helpers for checking the status of buried deployments.

This is a partial backport of core#19438
https://github.com/bitcoin/bitcoin/pull/19438/commits/2b0d291da8f479739ff394dd92801da8c40b9f8e#

Note that GetBlockScriptFlags is off-by-one when applied to mempool transaction in the source material, hence the use of DeploymentActiveAfter instead of DeploymentActiveAt in our codebase (see explanation in D3361).

Depends on D12219

Test Plan

ninja all check-all

Complete an IBD.

Event Timeline

PiRK requested review of this revision.Oct 12 2022, 12:50
Fabien requested changes to this revision.Oct 12 2022, 15:33
This revision now requires changes to proceed.Oct 12 2022, 15:33

@bot build-ibd

I'm running a proper IBD as well on a VPS

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"running"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "running"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:21:21] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script9054380275195816213
[16:21:21] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:21:21] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:21:21] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:21:21] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:21:21] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:21:24] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:21:24] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:21:49]W:	 [Step 1/1] Traceback (most recent call last):
[16:21:49]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:21:49]W:	 [Step 1/1]     main()
[16:21:49]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:21:49]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:21:49]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:21:49]W:	 [Step 1/1]     self.load(build_name)
[16:21:49]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:21:49]W:	 [Step 1/1]     raise AssertionError(
[16:21:49]W:	 [Step 1/1] AssertionError: running is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:21:49]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:21:49]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:21:54]W:	 [Step 1/1] Process exited with code 1
[16:21:54]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:21:55]E:	 [Step 1/1] Step Command Line failed
[16:21:55]E: Ant JUnit report watcher
[16:21:55]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:21:55]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:21:55]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:21:55] : Publishing internal artifacts (2s)
[16:21:57] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:21:57] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:21:55]W: Publishing artifacts (2s)
[16:21:55] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:21:55]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:21:58] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"VPS"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "VPS"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:22:17] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script245697082502426457
[16:22:17] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:22:17] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:22:17] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:22:17] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:22:17] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:22:21] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:22:21] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:22:42]W:	 [Step 1/1] Traceback (most recent call last):
[16:22:42]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:22:42]W:	 [Step 1/1]     main()
[16:22:42]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:22:42]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:22:42]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:22:42]W:	 [Step 1/1]     self.load(build_name)
[16:22:42]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:22:42]W:	 [Step 1/1]     raise AssertionError(
[16:22:42]W:	 [Step 1/1] AssertionError: VPS is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:22:42]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:22:42]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:22:47]W:	 [Step 1/1] Process exited with code 1
[16:22:47]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:22:47]E:	 [Step 1/1] Step Command Line failed
[16:22:47]E: Ant JUnit report watcher
[16:22:47]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:22:47]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:22:47]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:22:48] : Publishing internal artifacts (5s)
[16:22:52] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:22:52] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:22:48]W: Publishing artifacts (5s)
[16:22:48] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:22:48]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:22:54] : Build finished

Tail of the build log:

CACHE_HASH=$(git rev-parse --short HEAD~)
HASH=$(git rev-parse --short HEAD)
popd

RESULTS_DIR=$(pwd)/results

echo "Building base image for: ${HASH}..."

# Note: ERROR_PREFIX needs to be broken up here because this script gets copied into the build log.
# Not doing this results in all errors being treated as infra failures.
ERROR_PREFIX=$(echo "[Infrastructure" "Error]")
export ERROR_PREFIX

~/infra/ci-wrappers/build-abc-base-image.sh -c ./bitcoin-abc \
  --cachetagname abc-base-image-"${CACHE_HASH}" \
  -t abc-base-image-"${HASH}" debian:bullseye

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"'I'"'"'m'"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "'I'"'"'m'"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:23:16] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script1784581522301701944
[16:23:16] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:23:16]W:	 [Step 1/1] /home/teamcity/buildAgent/temp/agentTmp/custom_script1784581522301701944: line 49: syntax error near unexpected token `}'
[16:23:16]W:	 [Step 1/1] /home/teamcity/buildAgent/temp/agentTmp/custom_script1784581522301701944: line 49: `}'
[16:23:16]W:	 [Step 1/1] Process exited with code 2
[16:23:16]E:	 [Step 1/1] Process exited with code 2 (Step: Command Line)
[16:23:16]E:	 [Step 1/1] Step Command Line failed
[16:23:17]E: Ant JUnit report watcher
[16:23:17]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:23:17]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:23:17]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:23:17] : Publishing internal artifacts (4s)
[16:23:21] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:23:21] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:23:17]W: Publishing artifacts (4s)
[16:23:17] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:23:17]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:23:22] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"as"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "as"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:23:13] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script917823471005982369
[16:23:13] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:23:13] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:23:13] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:23:13] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:23:13] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:23:16] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:23:16] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:23:37]W:	 [Step 1/1] Traceback (most recent call last):
[16:23:37]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:23:37]W:	 [Step 1/1]     main()
[16:23:37]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:23:37]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:23:37]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:23:37]W:	 [Step 1/1]     self.load(build_name)
[16:23:37]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:23:37]W:	 [Step 1/1]     raise AssertionError(
[16:23:37]W:	 [Step 1/1] AssertionError: as is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:23:37]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:23:37]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:23:42]W:	 [Step 1/1] Process exited with code 1
[16:23:42]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:23:42]E:	 [Step 1/1] Step Command Line failed
[16:23:42]E: Ant JUnit report watcher
[16:23:42]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:23:42]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:23:42]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:23:42] : Publishing internal artifacts (1s)
[16:23:43] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:23:43] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:23:42]W: Publishing artifacts (1s)
[16:23:42] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:23:42]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:23:45] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"IBD"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "IBD"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:23:42] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script6035743882468788767
[16:23:42] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:23:42] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:23:42] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:23:42] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:23:42] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:23:45] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:23:45] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:24:06]W:	 [Step 1/1] Traceback (most recent call last):
[16:24:06]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:24:06]W:	 [Step 1/1]     main()
[16:24:06]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:24:06]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:24:06]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:24:06]W:	 [Step 1/1]     self.load(build_name)
[16:24:06]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:24:06]W:	 [Step 1/1]     raise AssertionError(
[16:24:06]W:	 [Step 1/1] AssertionError: IBD is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:24:06]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:24:06]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:24:11]W:	 [Step 1/1] Process exited with code 1
[16:24:11]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:24:11]E:	 [Step 1/1] Step Command Line failed
[16:24:12]E: Ant JUnit report watcher
[16:24:12]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:24:12]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:24:12]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:24:12] : Publishing internal artifacts (5s)
[16:24:17] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:24:17] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:24:12]W: Publishing artifacts (6s)
[16:24:12] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:24:12]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:24:18] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"on"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "on"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:24:04] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script1175343244175166695
[16:24:04] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:24:04] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:04] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:04] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:24:04] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:07] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:07] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:24:26]W:	 [Step 1/1] Traceback (most recent call last):
[16:24:26]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:24:26]W:	 [Step 1/1]     main()
[16:24:26]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:24:26]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:24:26]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:24:26]W:	 [Step 1/1]     self.load(build_name)
[16:24:26]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:24:26]W:	 [Step 1/1]     raise AssertionError(
[16:24:26]W:	 [Step 1/1] AssertionError: on is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:24:26]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:24:26]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:24:31]W:	 [Step 1/1] Process exited with code 1
[16:24:31]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:24:31]E:	 [Step 1/1] Step Command Line failed
[16:24:32]E: Ant JUnit report watcher
[16:24:32]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:24:32]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:24:32]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:24:32] : Publishing internal artifacts (2s)
[16:24:34] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:24:34] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:24:32]W: Publishing artifacts (3s)
[16:24:32] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:24:32]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:24:36] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"a"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "a"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:24:37] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script1504173597452269678
[16:24:37] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:24:37] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:37] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:37] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:24:37] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:41] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:41] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:25:01]W:	 [Step 1/1] Traceback (most recent call last):
[16:25:01]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:25:01]W:	 [Step 1/1]     main()
[16:25:01]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:25:01]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:25:01]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:25:01]W:	 [Step 1/1]     self.load(build_name)
[16:25:01]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:25:01]W:	 [Step 1/1]     raise AssertionError(
[16:25:01]W:	 [Step 1/1] AssertionError: a is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:25:01]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:25:01]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:25:05]W:	 [Step 1/1] Process exited with code 1
[16:25:05]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:25:05]E:	 [Step 1/1] Step Command Line failed
[16:25:06]E: Ant JUnit report watcher
[16:25:06]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:25:06]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:25:06]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:25:06] : Publishing internal artifacts (2s)
[16:25:07] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:25:08] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:25:06]W: Publishing artifacts (2s)
[16:25:06] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:25:06]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:25:09] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"proper"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "proper"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:24:55] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script3148999087042683451
[16:24:55] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:24:55] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:55] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:55] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:24:55] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:24:58] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:24:58] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:25:17]W:	 [Step 1/1] Traceback (most recent call last):
[16:25:17]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:25:17]W:	 [Step 1/1]     main()
[16:25:17]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:25:17]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:25:17]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:25:17]W:	 [Step 1/1]     self.load(build_name)
[16:25:17]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:25:17]W:	 [Step 1/1]     raise AssertionError(
[16:25:17]W:	 [Step 1/1] AssertionError: proper is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:25:17]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:25:17]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:25:22]W:	 [Step 1/1] Process exited with code 1
[16:25:22]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:25:23]E:	 [Step 1/1] Step Command Line failed
[16:25:23]E: Ant JUnit report watcher
[16:25:23]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:25:23]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:25:23]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:25:23] : Publishing internal artifacts (1s)
[16:25:24] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:25:25] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:25:23]W: Publishing artifacts (2s)
[16:25:23] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:25:23]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:25:26] : Build finished

Tail of the build log:

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"well"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
export SDK_DL_REMOTE="http://ci.fabien.cash"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "well"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[16:25:24] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script5550310763089889735
[16:25:24] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[16:25:24] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:25:24] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:25:24] :	 [Step 1/1] Building base image for: 883b9cd18...
[16:25:24] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[16:25:26] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[16:25:26] :	 [Step 1/1] Tag name: abc-base-image-883b9cd18
[16:25:45]W:	 [Step 1/1] Traceback (most recent call last):
[16:25:45]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 573, in <module>
[16:25:45]W:	 [Step 1/1]     main()
[16:25:45]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 561, in main
[16:25:45]W:	 [Step 1/1]     build_configuration = BuildConfiguration(
[16:25:45]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 59, in __init__
[16:25:45]W:	 [Step 1/1]     self.load(build_name)
[16:25:45]W:	 [Step 1/1]   File "/work/./contrib/teamcity/build-configurations.py", line 80, in load
[16:25:45]W:	 [Step 1/1]     raise AssertionError(
[16:25:45]W:	 [Step 1/1] AssertionError: well is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[16:25:45]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[16:25:45]W:	 [Step 1/1] Try 'mv --help' for more information.
[16:25:50]W:	 [Step 1/1] Process exited with code 1
[16:25:50]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[16:25:50]E:	 [Step 1/1] Step Command Line failed
[16:25:51]E: Ant JUnit report watcher
[16:25:51]E:	 [Ant JUnit report watcher] No reports found for paths:
[16:25:51]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[16:25:51]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[16:25:51] : Publishing internal artifacts (3s)
[16:25:53] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[16:25:53] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[16:25:51]W: Publishing artifacts (3s)
[16:25:51] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[16:25:51]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[16:25:55] : Build finished
PiRK requested review of this revision.Oct 13 2022, 04:40
PiRK edited the test plan for this revision. (Show Details)

Updated test plan after successfull IBD.

This revision is now accepted and ready to land.Oct 13 2022, 08:00
This revision was automatically updated to reflect the committed changes.