Page MenuHomePhabricator
Differential D12226

[refactor] Move ComputeBlockVersion into VersionBitsCache
ClosedPublic
Actions

Authored by PiRK on Oct 12 2022, 15:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcddd805bc166: [refactor] Move ComputeBlockVersion into VersionBitsCache
Summary

This also changes ComputeBlockVersion to take the versionbits cache mutex once, rather than once for each versionbits deployment.

This concludes backport of core#19438
https://github.com/bitcoin/bitcoin/pull/19438/commits/4a69b4dbe0d7f504811b67c399da7e6d11e4f805
https://github.com/bitcoin/bitcoin/pull/19438/commits/c5f36725e877d8eb492383844f8ef7535466b366
https://github.com/bitcoin/bitcoin/pull/19438/commits/e48826ad87b4f92261f7433e84f48dac9bd9e5c3

Depends on D12225

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2022, 15:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 15:10
PiRK requested review of this revision.Oct 12 2022, 15:10
teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 15:10
PiRK edited the summary of this revision. (Show Details)Oct 12 2022, 15:11
PiRK added a parent revision: D12225: [refactor] versionbits: make VersionBitsCache a full class.
Harbormaster completed remote builds in B20471: Diff 35624.Oct 12 2022, 15:33
Fabien requested changes to this revision.Oct 12 2022, 16:06
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/versionbits.cpp
252 ↗(On Diff #35624)

Use a proper constructor

This revision now requires changes to proceed.Oct 12 2022, 16:06
PiRK updated this revision to Diff 35636.Oct 13 2022, 05:27

(int)... --> int(...)

Harbormaster completed remote builds in B20480: Diff 35636.Oct 13 2022, 05:47
Fabien accepted this revision.Oct 13 2022, 08:19
Fabien added inline comments.
src/versionbits.cpp
252 ↗(On Diff #35636)

int{}

This revision is now accepted and ready to land.Oct 13 2022, 08:19
PiRK updated this revision to Diff 35654.Oct 13 2022, 09:17

int{}

This revision was landed with ongoing or failed builds.Oct 13 2022, 09:43
Closed by commit rABCcddd805bc166: [refactor] Move ComputeBlockVersion into VersionBitsCache (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCcddd805bc166: [refactor] Move ComputeBlockVersion into VersionBitsCache.
Harbormaster completed remote builds in B20488: Diff 35654.Oct 13 2022, 10:07

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
66 lines
6 lines
18 lines
6 lines
19 lines

Diff 35657

View Options

src/miner.cpp

Loading...
View Options

src/test/versionbits_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/versionbits.h

Loading...
View Options

src/versionbits.cpp

Loading...