Crash debug builds when mempool ConsensusScriptChecks fails
ClosedPublic
Actions

Authored by PiRK on Nov 3 2022, 11:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd2f5796b2d0c: Crash debug builds when mempool ConsensusScriptChecks fails

Summary

Currently a bug in the function might sneak around our testing infrastructure.

Fix that by turning bugs into crashes during tests.

This is a backport of core#23590

Test Plan

With and without DEBUG:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr23590

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20804
Build 41268: Build Diff	build-without-wallet · build-diff · build-debug · lint-circular-dependencies · build-clang · build-clang-tidy
Build 41267: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 3 2022, 11:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2022, 11:56

PiRK requested review of this revision.Nov 3 2022, 11:56

teamcity edited the summary of this revision. (Show Details)Nov 3 2022, 11:56

Harbormaster completed remote builds in B20804: Diff 36127.Nov 3 2022, 12:12

Fabien accepted this revision.Nov 3 2022, 12:23

This revision is now accepted and ready to land.Nov 3 2022, 12:23

Closed by commit rABCd2f5796b2d0c: Crash debug builds when mempool ConsensusScriptChecks fails (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 7 2022, 12:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd2f5796b2d0c: Crash debug builds when mempool ConsensusScriptChecks fails.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

7 lines

Diff 36127

View Options

Crash debug builds when mempool ConsensusScriptChecks failsClosedPublicActions