Paths

Table of Contentst

Differential D12489

[Cashtab] [ECPair from wif p2] Deprecate BCH method
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 11:21.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

T2730

Depends on D12488

Remove BCH param from function and migrate to new local method

Test Plan

npm test and confirm existing unit tests of function that depends on this param still work
npm start, send some transactions, confirm they work

Diff Detail

Repository

rABC Bitcoin ABC

Branch

local-ecpair

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20914
Build 41485: Build Diff	cashtab-tests
Build 41484: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 11:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 11:21

bytesofman requested review of this revision.Nov 15 2022, 11:21

bytesofman added a child revision: D12490: [Cashtab] [ECPair from wif p3] Consistent camel case for ECPair.Nov 15 2022, 11:24

Harbormaster completed remote builds in B20914: Diff 36298.Nov 15 2022, 11:40

emack accepted this revision.Nov 18 2022, 11:12

This revision is now accepted and ready to land.Nov 18 2022, 11:12

rebase

Harbormaster completed remote builds in B21073: Diff 36546.Nov 23 2022, 10:57

Superseded by D12618

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__tests__/

cashMethods.test.js

2 lines

cashMethods.js

19 lines

Diff 36298

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] [ECPair from wif p2] Deprecate BCH methodAbandonedPublicActions