Paths

Table of Contentst

Differential D12512

Move blockstorage-related unload to BlockManager::Unload
ClosedPublic
Actions

Authored by PiRK on Nov 16 2022, 16:05.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCd218c9c0304e: Move blockstorage-related unload to BlockManager::Unload

Summary

This is a refactor and safe to do because:

UnloadBlockIndex calls ChainstateManager::Unload, which calls BlockManager::Unload
Only unit tests call Unload directly

This is a partial backport of core#23974
https://github.com/bitcoin/bitcoin/pull/23974/commits/fab262174b96854d2df5bee7da578990c9e9cb1e

Depends on D12511

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20947
Build 41550: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 41549: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 16 2022, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2022, 16:05

PiRK requested review of this revision.Nov 16 2022, 16:05

teamcity edited the summary of this revision. (Show Details)Nov 16 2022, 16:05

PiRK added a child revision: D12513: test: Load genesis block to allow flush.Nov 16 2022, 16:06

Harbormaster completed remote builds in B20947: Diff 36342.Nov 16 2022, 16:46

sdulfari accepted this revision.Nov 17 2022, 00:06

This revision is now accepted and ready to land.Nov 17 2022, 00:06

Closed by commit rABCd218c9c0304e: Move blockstorage-related unload to BlockManager::Unload (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 17 2022, 10:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd218c9c0304e: Move blockstorage-related unload to BlockManager::Unload.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.cpp

5 lines

validation.cpp

4 lines

Diff 36342

View Options

src/node/blockstorage.cpp