Page MenuHomePhabricator
Differential D12592

[Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array
ClosedPublic
Actions

Authored by bytesofman on Nov 23 2022, 08:58.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC70c305861afc: [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array
Summary

T2663

Depends on D12590

Remove repeated tokens object. This is used nowhere in the app and can simply be removed.

Test Plan

npm start
Wait for update to run at least once and to see dev log msg confirming updated wallet has been saved to storage
Change wallets
Wait for update to run at least once and to see dev log msg confirming updated wallet has been saved to storage
Change back
Review local storage. Click 'update' to refresh local storage display. Confirm that the wallet you used is saved without the duplicate tokens array under savedWallets

grep -r slpBalancesAndUtxos.tokens src/ has no output
Review grep -r slpBalancesAndUtxos to confirm these references are not using the slpBalancesAndUtxos.tokens array

Diff Detail

Repository
rABC Bitcoin ABC
Branch
streamline-wallet-structure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21065
Build 41784: Build Diffcashtab-tests
Build 41783: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 23 2022, 08:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2022, 08:58
bytesofman requested review of this revision.Nov 23 2022, 08:58
Harbormaster completed remote builds in B21065: Diff 36537.Nov 23 2022, 09:03
bytesofman added a child revision: D12593: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array.Nov 23 2022, 09:11
emack requested changes to this revision.Nov 24 2022, 01:02
emack added a subscriber: emack.

I'm still seeing the tokens array inside slpBalancesAndUtxos object

image.png (589×487 px, 70 KB)

Also double checking, is this now the Update indicator in the console log?

image.png (123×372 px, 25 KB)

This revision now requires changes to proceed.Nov 24 2022, 01:02
bytesofman updated this revision to Diff 36611.Nov 25 2022, 10:29

Better dev logging

Harbormaster completed remote builds in B21129: Diff 36611.Nov 25 2022, 10:32
bytesofman edited the test plan for this revision. (Show Details)Nov 25 2022, 10:33
emack accepted this revision.Nov 25 2022, 11:00
This revision is now accepted and ready to land.Nov 25 2022, 11:00
bytesofman updated this revision to Diff 36687.Nov 26 2022, 07:41

rebase

Harbormaster completed remote builds in B21175: Diff 36687.Nov 26 2022, 07:44
bytesofman updated this revision to Diff 36723.Nov 28 2022, 04:49

rebase

Harbormaster completed remote builds in B21197: Diff 36723.Nov 28 2022, 05:08
bytesofman updated this revision to Diff 36803.Nov 30 2022, 08:16

rebase

Harbormaster completed remote builds in B21253: Diff 36803.Nov 30 2022, 08:39
Closed by commit rABC70c305861afc: [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array (authored by bytesofman). · Explain WhyDec 1 2022, 07:57
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC70c305861afc: [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line

Diff 36537

View Options

web/cashtab/src/hooks/useWallet.js

Loading...