[Cashtab] [ECPair from wif p11] Sign msgs with ecash prefix in xecjs-message
AbandonedPublic
Actions

Authored by bytesofman on Nov 16 2022, 16:29.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

T2783

Depends on D12496

Sign messages with the ecash prefix

Test Plan

npm start
Sign a message
Verify the message
Confirm 'eCash signed message' appears in the dev log when you verify
Sign a message with cashtab.com or electrumabc as bitcoin signed
Confirm your npm start instance verifies this as well, but eCash signed message does not appear in the dev log

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21082
Build 41818: Build Diff
Build 41817: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 16 2022, 16:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2022, 16:29

bytesofman requested review of this revision.Nov 16 2022, 16:29

Harbormaster completed remote builds in B20950: Diff 36345.Nov 16 2022, 16:30

bytesofman edited the test plan for this revision. (Show Details)Nov 16 2022, 16:31

bytesofman added a child revision: D12516: [Cashtab] [ECPair from wif p12] Remove debug logging and async test.Nov 16 2022, 16:41

I'm not getting the 'eCash signed message' message regardless of whether it's ecash or bitcoin signed. Perhaps see if JSON.stringifying the signature buffer makes a difference?

This revision now requires changes to proceed.Nov 19 2022, 12:03

nvm, figured out the test plan needed a 'npm i' at the start otherwise it doesn't pick up the changes to the xecjs-message module. All good now.

This revision is now accepted and ready to land.Nov 19 2022, 12:07

rebase

Harbormaster completed remote builds in B21082: Diff 36555.Nov 23 2022, 11:07

bytesofman edited the summary of this revision. (Show Details)Nov 25 2022, 08:11

bytesofman added a parent revision: D12496: [Cashtab] [ECPair from wif p9] Remove unused imports from cashMethods.test.js.

Superseded by D12643