[net processing] Remove QueuedBlock.hash
ClosedPublic
Actions

Authored by PiRK on Nov 30 2022, 16:36.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC1a21825165b3: [net processing] Remove QueuedBlock.hash

Summary

It's redundant with CBlockIndex::GetBlockHash()

This is a partial backport of core#22141
https://github.com/bitcoin/bitcoin/pull/22141/commits/4e90d2dd0e91e7eb560f2c1b430f13c7a047804f

Depends on D12706

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21282
Build 42214: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42213: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 30 2022, 16:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2022, 16:36

PiRK requested review of this revision.Nov 30 2022, 16:36

teamcity edited the summary of this revision. (Show Details)Nov 30 2022, 16:36

PiRK added a child revision: D12708: [net processing] Add IsBlockRequested() function.Nov 30 2022, 16:39

Harbormaster completed remote builds in B21282: Diff 36837.Nov 30 2022, 17:26

sdulfari accepted this revision.Nov 30 2022, 17:40

This revision is now accepted and ready to land.Nov 30 2022, 17:40

Closed by commit rABC1a21825165b3: [net processing] Remove QueuedBlock.hash (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyDec 1 2022, 07:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1a21825165b3: [net processing] Remove QueuedBlock.hash.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

14 lines

Diff 36837

View Options

[net processing] Remove QueuedBlock.hashClosedPublicActions