Differential D12737

test: Return new_utxo from create_self_transfer in MiniWallet
ClosedPublic
Actions

Authored by Fabien on Dec 2 2022, 20:05.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9811dc648f00: test: Return new_utxo from create_self_transfer in MiniWallet

Summary

I need this for some stuff, but it also makes sense on its own to:

    unify the flow with a private _create_utxo helper
    simplify the flow by giving the caller ownership of the utxo right away

Backport of core#25445.

Depends on D12736.

Note that all the changes are not applicable to our codebase but the most important ones do.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25445

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21329
Build 42308: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42307: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 2 2022, 20:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2022, 20:05

Fabien requested review of this revision.Dec 2 2022, 20:05

teamcity edited the summary of this revision. (Show Details)Dec 2 2022, 20:05

Fabien added a child revision: D12739: test: USDT tracepoint interface tests.Dec 2 2022, 20:36

Harbormaster completed remote builds in B21329: Diff 36919.Dec 2 2022, 20:36

PiRK accepted this revision.Dec 3 2022, 14:22

This revision is now accepted and ready to land.Dec 3 2022, 14:22

Closed by commit rABC9811dc648f00: test: Return new_utxo from create_self_transfer in MiniWallet (authored by MacroFake <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 3 2022, 14:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9811dc648f00: test: Return new_utxo from create_self_transfer in MiniWallet.

Revision Contents
Changeset List

Path

Size

test/

functional/

mempool_reorg.py

8 lines

test_framework/

47 lines

Diff 36919

test/functional/mempool_reorg.py

Loading...

test/functional/test_framework/wallet.py

Loading...