ci: ubsan report_error_type=1 and add suppressions
ClosedPublic
Actions

Authored by PiRK on Dec 7 2022, 16:43.

Details

Reviewers

sdulfari
Fabien

Group Reviewers

Restricted Project

Commits

rABCeae5b5155723: ci: ubsan report_error_type=1 and add suppressions

Summary

This is a partial backport of core#17517, core#20430 and core#20844
https://github.com/bitcoin/bitcoin/pull/17517/commits/fa1bfc476c9208a4c412c8ca74d05f52bb47766f

Test Plan

With UBSAN:

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21431
Build 42512: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42511: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 7 2022, 16:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2022, 16:43

PiRK requested review of this revision.Dec 7 2022, 16:43

teamcity edited the summary of this revision. (Show Details)Dec 7 2022, 16:43

PiRK added a child revision: D12798: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback.Dec 7 2022, 16:45

@bot build-ubsan

teamcity awarded a token.Dec 7 2022, 16:47

Harbormaster completed remote builds in B21431: Diff 37067.Dec 7 2022, 17:09

Build Bitcoin ABC Diffs / Diff Testing (build-ubsan) failed.

Tail of the build log:

[522/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionview.cpp.o
[523/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletframe.cpp.o
[524/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiontablemodel.cpp.o
[525/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentrequestplus.cpp.o
[526/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletcontroller.cpp.o
[527/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsdialog.cpp.o
[528/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletview.cpp.o
[529/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodel.cpp.o
[530/535] Linking CXX static library src/qt/libbitcoin-qt-base.a
[531/535] Automatic MOC for target bitcoin-qt
[532/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[533/535] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[534/535] Linking CXX executable src/qt/bitcoin-qt
[534/535] Install the project...
-- Install configuration: "RelWithDebInfo"
-- Installing: /results/artifacts/lib/libbitcoinconsensus.so.0.26.8
-- Installing: /results/artifacts/lib/libbitcoinconsensus.so.0
-- Installing: /results/artifacts/lib/libbitcoinconsensus.so
-- Installing: /results/artifacts/include/bitcoinconsensus.h
-- Installing: /results/artifacts/bin/bitcoin-wallet
-- Installing: /results/artifacts/bin/bitcoin-seeder
-- Installing: /results/artifacts/bin/bitcoin-cli
-- Installing: /results/artifacts/bin/bitcoin-tx
-- Installing: /results/artifacts/bin/bitcoind
-- Installing: /results/artifacts/bin/bitcoin-qt
[1/481] Generating data/base58_encode_decode.json.h
[2/481] Generating data/key_io_invalid.json.h
[3/481] Generating data/blockfilters.json.h
[4/481] Generating data/key_io_valid.json.h
[5/481] Generate ASMAP header from data/asmap.raw
[6/481] Generating data/tx_invalid.json.h
[7/481] Generating data/tx_valid.json.h
[8/481] Generating data/script_tests.json.h
[9/481] Generating data/sighash.json.h
[10/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/fixture.cpp.o
[11/481] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/fixture.cpp.o
[12/481] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/jsonutil.cpp.o
[13/481] Building C object src/secp256k1/CMakeFiles/secp256k1-exhaustive_tests.dir/src/tests_exhaustive.c.o
[14/481] Linking C executable src/secp256k1/secp256k1-exhaustive_tests
[15/481] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sigutil.cpp.o
[16/481] secp256k1: testing secp256k1-exhaustive_tests
FAILED: src/secp256k1/CMakeFiles/check-secp256k1-secp256k1-exhaustive_tests 
cd /work/abc-ci-builds/build-ubsan/src/secp256k1 && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-ubsan/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-ubsan/test/log && /usr/bin/cmake -E env UBSAN_OPTIONS=suppressions=/work/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1log_path=stdout /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-ubsan/test/log/secp256k1-secp256k1-exhaustive_tests.log /work/abc-ci-builds/build-ubsan/src/secp256k1/secp256k1-exhaustive_tests
ERROR: Invalid value for bool option: '1log_path=stdout'
UndefinedBehaviorSanitizer: ERROR: Flag parsing failed.
[17/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/init_tests.cpp.o
[18/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/proofcomparator_tests.cpp.o
[19/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/delegation_tests.cpp.o
[20/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/util.cpp.o
[21/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/voterecord_tests.cpp.o
[22/481] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/scriptflags.cpp.o
[23/481] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_test_fixture.cpp.o
[24/481] Building C object src/secp256k1/CMakeFiles/secp256k1-tests.dir/src/tests.c.o
[25/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/compactproofs_tests.cpp.o
[26/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/proof_tests.cpp.o
[27/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/proofpool_tests.cpp.o
[28/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/peermanager_tests.cpp.o
[29/481] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
ninja: build stopped: subcommand failed.
Build build-ubsan failed with exit code 1

back to you

This revision now requires changes to proceed.Dec 7 2022, 19:13

Fabien added a subscriber: Fabien.Dec 7 2022, 20:06

Fabien added inline comments.

cmake/modules/Sanitizers.cmake
54

fix UBSAN_OPTIONS

@bot build-ubsan

teamcity updated a token.Dec 8 2022, 07:24

Harbormaster completed remote builds in B21451: Diff 37098.Dec 8 2022, 07:55

The backport is correct but please follow up with suppressions removal and investigations.

test/sanitizer_suppressions/ubsan
41 ↗	(On Diff #37098)	I don't like that at all, please take care to keep on with PR21000 to make it include path agnostic
56 ↗	(On Diff #37098)	This one is a bit worrying, do you know what it's for ?
64 ↗	(On Diff #37098)	Can you investigate on that one ? We're about to make changes there, I'd rather have the sanitizer not dismiss the file completely.
66 ↗	(On Diff #37098)	Please backport asap PR23795 as a follow up