T2730
Combining parts 4 through 7 of this diff that is already up, due to arcanist errors in squashing that stacked diff.
Details
Details
- Reviewers
kieran709 - Group Reviewers
Restricted Project - Commits
- rABC16fc8ef2f07c: [Cashtab] [final countdown bch param p4 thru p7]
See test plans of parts 4 through 7, already up.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- p4-thru-p7-recreate-t2730
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21491 Build 42630: Build Diff cashtab-tests Build 42629: arc lint + arc unit
Event Timeline
| web/cashtab/src/components/Send/SendToken.js | ||
|---|---|---|
| 187 | Flagging that in the previously accepted pts 4 through 7 this line isn't marked as changed. | |
Comment Actions
When sending an encrypted msg, the wallet that sent the encrypted msg repeatedly fires this warning. Tested on a wallet with no recent outgoing encrypted msgs and didn't get the error. I assume this isn't a big deal but wanted to flag it in case it is unexpected behavior.
Update: this error does not appear to be related to this diff
Comment Actions
When sending an encrypted msg, the wallet that sent the encrypted msg repeatedly fires this warning. Tested on a wallet with no recent outgoing encrypted msgs and didn't get the error. I assume this isn't a big deal but wanted to flag it in case it is unexpected behavior.
Do you see the same msg at cashtab.com for this wallet?
| web/cashtab/src/components/Send/SendToken.js | ||
|---|---|---|
| 187 | Good catch. I made this change to part 2 this morning and did not propagate the rebase into parts 4 through 7 that were pushed to phab. Will add it in here. | |