Page MenuHomePhabricator
Differential D12929

[linter] Remove and disallow js commented code
ClosedPublic
Actions

Authored by Fabien on Dec 20 2022, 16:21.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC45b927480cc4: [linter] Remove and disallow js commented code
Summary

Commented code should be either uncommented or removed.

Depends on D12926.

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
eslint_no_commented_code
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21648
Build 42936: Build Diffcashtab-tests
Build 42935: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 20 2022, 16:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2022, 16:21
Fabien requested review of this revision.Dec 20 2022, 16:21
Harbormaster completed remote builds in B21648: Diff 37394.Dec 20 2022, 16:34
bytesofman requested changes to this revision.Dec 21 2022, 12:59
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
web/cashtab/src/utils/cashMethods.js
184

the types object is helpful for explaining where 148*4 and 34*4 are coming from, should be modified like //Transaction details above in mockTxBuilderObj.js

This revision now requires changes to proceed.Dec 21 2022, 12:59
Fabien updated this revision to Diff 37413.Dec 21 2022, 12:59
Fabien removed a reviewer: bytesofman.

Rebase

Harbormaster completed remote builds in B21663: Diff 37413.Dec 21 2022, 13:01
Fabien updated this revision to Diff 37414.Dec 21 2022, 13:03

Undo removal as requested

bytesofman accepted this revision.Dec 21 2022, 13:04
This revision is now accepted and ready to land.Dec 21 2022, 13:04
Harbormaster completed remote builds in B21664: Diff 37414.Dec 21 2022, 13:06
Closed by commit rABC45b927480cc4: [linter] Remove and disallow js commented code (authored by Fabien). · Explain WhyDec 21 2022, 13:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC45b927480cc4: [linter] Remove and disallow js commented code.

Revision Contents
Changeset List

PathSize
web/
cashtab/
7 lines
config/
1 line
extension/
src/
2 lines
216 lines
1 line
src/
components/
Common/
15 lines
Send/
12 lines
12 lines
Tokens/
1 line
hooks/
22 lines
1 line
utils/
1 line
__mocks__/
26 lines
__tests__/
2 lines
10 lines

Diff 37394

View Options

web/cashtab/.eslintrc.js

Loading...
View Options

web/cashtab/config/webpack.config.js

Loading...
View Options

web/cashtab/extension/src/contentscript.js

Loading...
View Options

web/cashtab/package-lock.json

Loading...
View Options

web/cashtab/package.json

Loading...
View Options

web/cashtab/src/components/Common/ScanQRCode.js

Loading...
View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/components/Tokens/CreateTokenForm.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/hooks/useWebAuthentication.js

Loading...
View Options

web/cashtab/src/utils/GoogleAnalytics.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/mockTxBuilderObj.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...