Page MenuHomePhabricator
Differential D12994

style: Modernize range-based loops over m_block_index
ClosedPublic
Actions

Authored by PiRK on Jan 18 2023, 13:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCed473c9a8dd1: style: Modernize range-based loops over m_block_index
Summary

This concludes backport of core#24050
https://github.com/bitcoin/bitcoin/pull/24050/commits/c05cf7aa1e1c15089753897a10c14762027d4b99

Depends on D12993

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jan 18 2023, 13:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 13:59
PiRK requested review of this revision.Jan 18 2023, 13:59
teamcity edited the summary of this revision. (Show Details)Jan 18 2023, 13:59
Harbormaster completed remote builds in B21777: Diff 37576.Jan 18 2023, 14:11
Fabien mentioned this in D12991: blockstorage: Make m_block_index own CBlockIndex's.Jan 19 2023, 09:06
Fabien requested changes to this revision.Jan 19 2023, 09:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/blockstorage.cpp
244

you missed this one

245

See comment below

246

also please use the suggestion from https://github.com/bitcoin/bitcoin/pull/24050/commits/c05cf7aa1e1c15089753897a10c14762027d4b99#r792878138 and use emplace_back instead of reconstructing a pair.

426–431

The pointer is not necessary

src/validation.cpp
3560

Macro startrekagree:

5223

That should be const, but let's leave that for another diff as it requires other unrelated changes

This revision now requires changes to proceed.Jan 19 2023, 09:24
PiRK updated this revision to Diff 37612.Jan 20 2023, 09:49

address review

Harbormaster completed remote builds in B21804: Diff 37612.Jan 20 2023, 10:10
Fabien accepted this revision.Jan 20 2023, 13:08
This revision is now accepted and ready to land.Jan 20 2023, 13:08
Closed by commit rABCed473c9a8dd1: style: Modernize range-based loops over m_block_index (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 20 2023, 15:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCed473c9a8dd1: style: Modernize range-based loops over m_block_index.
PiRK mentioned this in D13021: style-only: No need for std::pair for vSortedByHeight.Jan 23 2023, 10:13
PiRK mentioned this in rABCcecbcba200c8: style-only: No need for std::pair for vSortedByHeight.Jan 23 2023, 15:48

Revision Contents
Changeset List

PathSize
src/
node/
4 lines
rpc/
9 lines
25 lines

Diff 37576

View Options

src/node/blockstorage.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.cpp

Loading...