Differential D12996

Move the overloaded template to its own header/namespace
ClosedPublic
Actions

Authored by Fabien on Jan 18 2023, 15:19.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC3d575c833d55: Move the overloaded template to its own header/namespace

Summary

It is a generic helper and doesn't belong to the avalanche namespace.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move_overloaded

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21779
Build 43193: Build Diff	build-debug · lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 43192: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 18 2023, 15:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 15:19

Fabien requested review of this revision.Jan 18 2023, 15:19

Harbormaster completed remote builds in B21779: Diff 37579.Jan 18 2023, 15:33

Fabien added a child revision: D12998: [avalanche] Leverage AnyVoteItem to have a single VoteItemUpdate object.Jan 18 2023, 15:43

sdulfari accepted this revision.Jan 18 2023, 17:32

This revision is now accepted and ready to land.Jan 18 2023, 17:32

Closed by commit rABC3d575c833d55: Move the overloaded template to its own header/namespace (authored by Fabien). · Explain WhyJan 19 2023, 08:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3d575c833d55: Move the overloaded template to its own header/namespace.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

7 lines

processor.cpp

2 lines

util/

variant.h

16 lines

Diff 37579

View Options

src/avalanche/processor.h

View Options

src/avalanche/processor.cpp

View Options

Move the overloaded template to its own header/namespaceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37579

src/avalanche/processor.h

src/avalanche/processor.cpp

src/util/variant.h

Move the overloaded template to its own header/namespace
ClosedPublic
Actions

Revision Contents
Changeset List