Differential D12997

[avalanche] Use the clear() method where applicable in the processor tests
ClosedPublic
Actions

Authored by Fabien on Jan 18 2023, 15:30.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCaf6ef90e05fe: [avalanche] Use the clear() method where applicable in the processor tests

Summary

No need to reconstruct the vector when we can clear it.

Test Plan

ninja check-avalanche-processor_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_test_updates_clear

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21780
Build 43195: Build Diff	lint-circular-dependencies · build-clang · build-without-wallet · build-diff · build-debug · build-clang-tidy
Build 43194: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 18 2023, 15:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 15:30

Fabien requested review of this revision.Jan 18 2023, 15:30

Fabien added a child revision: D12998: [avalanche] Leverage AnyVoteItem to have a single VoteItemUpdate object.Jan 18 2023, 15:43

Harbormaster completed remote builds in B21780: Diff 37580.Jan 18 2023, 15:46

sdulfari accepted this revision.Jan 18 2023, 17:32

This revision is now accepted and ready to land.Jan 18 2023, 17:32

Closed by commit rABCaf6ef90e05fe: [avalanche] Use the clear() method where applicable in the processor tests (authored by Fabien). · Explain WhyJan 19 2023, 08:47

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaf6ef90e05fe: [avalanche] Use the clear() method where applicable in the processor tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

4 lines

Diff 37580

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Use the clear() method where applicable in the processor testsClosedPublicActions