Require CBlockIndex::IsValid() to hold cs_main
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 07:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC20237dec6f59: Require CBlockIndex::IsValid() to hold cs_main

Summary

This is a partial backport of core#22932
https://github.com/bitcoin/bitcoin/pull/22932/commits/ca47b005770f71aa229ecc1f7b8146a96ff02151

Depends on D13035

Test Plan

With clang and DEBUG:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21829
Build 43293: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43292: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 24 2023, 07:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 07:17

PiRK requested review of this revision.Jan 24 2023, 07:17

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 07:18

PiRK added a child revision: D13037: Require IsBlockPruned() to hold mutex cs_main.Jan 24 2023, 07:19

Harbormaster completed remote builds in B21829: Diff 37654.Jan 24 2023, 08:03

Fabien accepted this revision.Jan 24 2023, 08:48

This revision is now accepted and ready to land.Jan 24 2023, 08:48

Closed by commit rABC20237dec6f59: Require CBlockIndex::IsValid() to hold cs_main (authored by PiRK). · Explain WhyJan 24 2023, 09:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC20237dec6f59: Require CBlockIndex::IsValid() to hold cs_main.

Revision Contents
Changeset List

Path

Size

src/

blockindex.h

4 lines

Diff 37654

View Options

Require CBlockIndex::IsValid() to hold cs_mainClosedPublicActions