Page MenuHomePhabricator
Differential D13040

Add benchmark to write JSON into a string
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 10:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa13b242fa6d4: Add benchmark to write JSON into a string
Summary

The benchmark BlockToJsonVerbose only tests generating (and destroying)
the JSON data structure, but serializing into a string is also a
performance critical aspect of the RPC calls.

Also, use ankerl::nanobench::doNotOptimizeAway to make sure the compiler
can't optimize the result of the calls away.

This is a backport of core#21170
Depends on D13039

Test Plan

ninja bench-bitcoin

Diff Detail

Event Timeline

PiRK created this revision.Jan 24 2023, 10:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 10:00
PiRK requested review of this revision.Jan 24 2023, 10:00
teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 10:00
Fabien accepted this revision.Jan 24 2023, 10:20
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bench/rpc_blockchain.cpp
44 ↗(On Diff #37668)
54 ↗(On Diff #37668)

dito

This revision is now accepted and ready to land.Jan 24 2023, 10:20
Harbormaster completed remote builds in B21835: Diff 37668.Jan 24 2023, 10:24
PiRK updated this revision to Diff 37671.Jan 24 2023, 10:28

fix clang-tidy named parameters

Harbormaster completed remote builds in B21837: Diff 37671.Jan 24 2023, 11:02
Closed by commit rABCa13b242fa6d4: Add benchmark to write JSON into a string (authored by Martin Ankerl <martin.ankerl@gmail.com>, committed by PiRK). · Explain WhyJan 24 2023, 11:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa13b242fa6d4: Add benchmark to write JSON into a string.

Revision Contents
Changeset List

PathSize
src/
bench/
50 lines

Diff 37671

View Options

src/bench/rpc_blockchain.cpp

Loading...