zmq: remove LOCK(cs_main) from NotifyBlock
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 16:34.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC3bac4c6a232f: zmq: remove LOCK(cs_main) from NotifyBlock

Summary

The second commit is from a suggestion on the original PR by jonatack to remove the unnecessary LOCK(cs_main) in the zmq notifier's NotifyBlock.

This is a partial backport of core#26308
https://github.com/bitcoin/bitcoin/pull/26308/commits/7d253c943f44612431be894b198ffb49ff988fff

Depends on D13052

Test Plan

With Clang and DEBUG:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21854
Build 43343: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43342: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 24 2023, 16:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 16:34

PiRK requested review of this revision.Jan 24 2023, 16:34

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 16:34

PiRK added a child revision: D13054: rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock.Jan 24 2023, 16:35

Harbormaster completed remote builds in B21854: Diff 37699.Jan 24 2023, 16:57

sdulfari accepted this revision.Jan 24 2023, 18:16

This revision is now accepted and ready to land.Jan 24 2023, 18:16

Closed by commit rABC3bac4c6a232f: zmq: remove LOCK(cs_main) from NotifyBlock (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyJan 25 2023, 07:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3bac4c6a232f: zmq: remove LOCK(cs_main) from NotifyBlock.

Revision Contents
Changeset List

Path

Size

src/

zmq/

zmqpublishnotifier.cpp

17 lines

Diff 37699

View Options

src/zmq/zmqpublishnotifier.cpp

zmq: remove LOCK(cs_main) from NotifyBlockClosedPublicActions