rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 16:35.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC60cd1c8b0da6: rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock

Summary

This is a partial backport of core#26308
https://github.com/bitcoin/bitcoin/pull/26308/commits/f00808e932c1f67bc76702a3f05778074b10025c

Depends on D13053

Test Plan

With Clang and DEBUG:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21855
Build 43345: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 43344: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 24 2023, 16:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 16:35

PiRK requested review of this revision.Jan 24 2023, 16:35

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 16:35

PiRK added a child revision: D13055: rpc: reduce LOCK(cs_main) scope in blockToJSON.Jan 24 2023, 16:36

Harbormaster completed remote builds in B21855: Diff 37700.Jan 24 2023, 17:03

sdulfari accepted this revision.Jan 24 2023, 18:18

This revision is now accepted and ready to land.Jan 24 2023, 18:18

Closed by commit rABC60cd1c8b0da6: rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyJan 25 2023, 07:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC60cd1c8b0da6: rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

22 lines

Diff 37700

View Options

rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblockClosedPublicActions