Page MenuHomePhabricator

[Cashtab] Match transaction input sequence to node and ElectrumABC
ClosedPublic

Authored by bytesofman on Jan 23 2023, 18:28.

Details

Summary

T2925

Match Cashtab txs sequence number for inputs to eCash node and ElectrumABC.

Note: this will be implemented by default in the Bitgo utxo-lib transaction builder after that is implemented. For now, just overwrite the existing default in functions.

Test Plan

npm start
Send every kind of tx
Inspect for "sequence": 4294967294 in the JSON tab at https://explorer.bitcoinabc.org/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tx-sequencing-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21862
Build 43359: Build Diffcashtab-tests
Build 43358: arc lint + arc unit

Event Timeline

Need to implement this in all the other tx building functions. May need to modify some unit test results.

implement in txbuilder, amend legacy unit tests

remove one-off implementation

Undo changes to transactions.js

This revision is now accepted and ready to land.Jan 24 2023, 23:55