Page MenuHomePhabricator

Add integration tests for sighashtype boundary condition
ClosedPublic

Authored by jasonbcox on May 7 2018, 14:50.

Details

Summary

Added cases for sighashtype with 0x20

Test Plan

make check
then copied the generated tests to script_tests.json and ran make check again to verify.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tests-final
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2534
Build 3187: Bitcoin ABC Buildbot (legacy)
Build 3186: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 7 2018, 15:10
deadalnix added inline comments.
src/test/data/script_tests.json
64

There is a section in that file for generated tests.

src/test/script_tests.cpp
431

This is already tested.

449

Put comment on their own line.

462

dito

476

dito

This revision now requires changes to proceed.May 7 2018, 15:10

Removed redundant tests and cleaned up comments

deadalnix requested changes to this revision.May 10 2018, 00:12
deadalnix added inline comments.
src/test/script_tests.cpp
449 ↗(On Diff #3859)

Can you reorder this to be located close to other test case that check similar pieces of code ?

926 ↗(On Diff #3859)

Here

This revision now requires changes to proceed.May 10 2018, 00:12

Moved to location in the code more relative to similar tests and added more informative test messages.

This revision is now accepted and ready to land.May 10 2018, 01:36
This revision was automatically updated to reflect the committed changes.