Page MenuHomePhabricator
Differential D13187

test: use f-strings in feature_* tests (part 2).
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 12:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbfadc796e682: test: use f-strings in feature_* tests (part 2).
Summary

This is a partial backport of core#22229
https://github.com/bitcoin/bitcoin/pull/22229/commits/a2502cc63fd308be8af840962da9c53339433fa6
https://github.com/bitcoin/bitcoin/pull/22229/commits/a2de33cbdc79202bccddb4beadfde88266ac979f
https://github.com/bitcoin/bitcoin/pull/22229/commits/ff7e3309995a8960ac371741b2b00c6da40f7490
https://github.com/bitcoin/bitcoin/pull/22229/commits/e9ca8b254d4b9567831c0e113ce1c0a2b4795a95
https://github.com/bitcoin/bitcoin/pull/22229/commits/fb633933ab570e945d2a366f37eeff39f516c613

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr22229
Lint
Lint Errors
SeverityLocationCodeMessage
Errortest/functional/feature_loadblock.py:53F541flake8 F541
Errortest/functional/feature_loadblock.py:54F541flake8 F541
Unit
No Test Coverage
Build Status
Buildable 22126
Build 43887: Build Diffbuild-debug · build-without-wallet · build-clang-tidy · build-clang · build-diff
Build 43886: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 28 2023, 12:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 12:29
PiRK requested review of this revision.Feb 28 2023, 12:29
Harbormaster completed remote builds in B22126: Diff 38096.Feb 28 2023, 12:29
teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 12:29
PiRK updated this revision to Diff 38097.Feb 28 2023, 12:31

don't use f-string without placeholder (this is legal, but unnecessary and it triggers a linter error)

Harbormaster completed remote builds in B22127: Diff 38097.Feb 28 2023, 12:48
Fabien accepted this revision.Feb 28 2023, 12:58
This revision is now accepted and ready to land.Feb 28 2023, 12:58
Closed by commit rABCbfadc796e682: test: use f-strings in feature_* tests (part 2). (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyFeb 28 2023, 13:29
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbfadc796e682: test: use f-strings in feature_* tests (part 2)..
PiRK mentioned this in D13191: test: use f-strings in feature_* tests (part 3, with flynt).Feb 28 2023, 15:59
PiRK mentioned this in rABCe3d2ac1fd3e4: test: use f-strings in feature_* tests (part 3, with flynt).Mar 1 2023, 09:38

Revision Contents
Changeset List

PathSize
test/
functional/
42 lines
4 lines
17 lines
6 lines
24 lines

Diff 38096

View Options

test/functional/feature_dbcrash.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/feature_filelock.py

Loading...
View Options

test/functional/feature_help.py

Loading...
View Options

test/functional/feature_loadblock.py

Loading...