This diff makes tx version 3 standard and consensus compliant after wellington activation. The versions 2 and 3 have similar meaning.
Depends on D13223.
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- tx_version3
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 22238 Build 44111: Build Diff build-without-wallet · lint-circular-dependencies · build-clang · build-clang-tidy · build-fuzzer · build-debug · build-diff Build 44110: arc lint + arc unit
Event Timeline
Comment Actions
There is a test in mempool_accept.py checking that version 3 is rejected from the mempool. Should this be addressed in this diff?
self.log.info('Some nonstandard transactions')
tx = FromHex(CTransaction(), raw_tx_reference)
tx.nVersion = 3 # A version currently non-standard
self.check_mempool_result(
result_expected=[
{'txid': tx.rehash(), 'allowed': False, 'reject-reason': 'version'}],
rawtxs=[ToHex(tx)],
)It is not wrong right now, but it will fail after wellington.
Comment Actions
After discussion with the various involved actors, I decided the benefit does not warrant the maintenance cost for this change.