Page MenuHomePhabricator
Differential D13250

[website] Update the upgrade page
ClosedPublic
Actions

Authored by Fabien on Mar 7 2023, 13:24.

Details

Reviewers
PiRK
Mengerian
Group Reviewers
Restricted Project
Commits
rABCWEB4c158d76dc49: [website] Update the upgrade page
Summary

Update the upgrade page with the changes from the next release.

Test Plan
make serve

Check the upgrade page renders correctly and the content is correct.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
upgrade_page
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22282
Build 44197: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 7 2023, 13:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2023, 13:24
Fabien requested review of this revision.Mar 7 2023, 13:24
Harbormaster completed remote builds in B22282: Diff 38329.Mar 7 2023, 13:24
PiRK accepted this revision.Mar 7 2023, 16:50
PiRK added a subscriber: PiRK.
PiRK added inline comments.
upgrade.html
11

nit: extra blank space

This revision is now accepted and ready to land.Mar 7 2023, 16:50
Mengerian added a subscriber: Mengerian.Mar 7 2023, 17:47

Need to update the upgrade notice also.

See D12036 for an example of what was done last time

upgrade.html
11
Mengerian requested changes to this revision.Mar 7 2023, 17:47
This revision now requires changes to proceed.Mar 7 2023, 17:47
Fabien updated this revision to Diff 38331.Mar 7 2023, 17:56

Also update the upgrade notice banner

Harbormaster completed remote builds in B22284: Diff 38331.Mar 7 2023, 17:56
Fabien updated this revision to Diff 38332.Mar 7 2023, 17:58

Feedback

Harbormaster completed remote builds in B22285: Diff 38332.Mar 7 2023, 17:58
Mengerian requested changes to this revision.Mar 7 2023, 18:13

Some more edits of wording.

I'd also consider removing the breaks in the the upgrade item paragraphs.

upgrade.html
16 ↗(On Diff #38332)
18 ↗(On Diff #38332)
20 ↗(On Diff #38332)
22 ↗(On Diff #38332)
This revision now requires changes to proceed.Mar 7 2023, 18:13
Fabien updated this revision to Diff 38333.Mar 7 2023, 19:15

Improve wording, remove line breaks

Harbormaster completed remote builds in B22286: Diff 38333.Mar 7 2023, 19:15
Mengerian accepted this revision.Mar 8 2023, 03:17

Words look good now.

One last thing is to improve the image, but we don't need to block on that.

This revision is now accepted and ready to land.Mar 8 2023, 03:17
Fabien updated this revision to Diff 38340.Mar 8 2023, 08:27

Update the image

Harbormaster completed remote builds in B22290: Diff 38340.Mar 8 2023, 08:27
Closed by commit rABCWEB4c158d76dc49: [website] Update the upgrade page (authored by Fabien). · Explain WhyMar 8 2023, 13:46
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCWEB4c158d76dc49: [website] Update the upgrade page.
aimal added a subscriber: aimal.Mar 8 2023, 14:01
aimal added inline comments.
upgrade.html
18 ↗(On Diff #38341)

Typo: missing "be" in here.

Revision Contents
Changeset List

Diff 38329

View Options

img/Upgrade-2022-11-15.jpg

Loading...
View Options

img/Upgrade-2023-05-15.jpg

Loading...
View Options

upgrade.html

Loading...