Page MenuHomePhabricator
Differential D13256

[cashtab-componets] npm module maintenance
ClosedPublic
Actions

Authored by bytesofman on Mar 8 2023, 18:01.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCe43c035c8780: [cashtab-componets] npm module maintenance
Summary

T2979

Running npm audit fix

Note: still have some vulnerabilities related to storybook. This is not used in prod except for examples, so severity is lower.

Test Plan

npm run storybook and test with extension

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-components-npm-maint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22308
Build 44242: Build Diffcashtab-components-tests
Build 44241: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 8 2023, 18:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2023, 18:01
bytesofman requested review of this revision.Mar 8 2023, 18:01
bytesofman added a comment.Mar 8 2023, 18:02

As a separate issue, cashtab-components and its dependencies needs to be re-evaluated. This has been postponed since the dependencies are not the highest priority improvement for cashtab-components, and use is still minimal.

A 3mb package-lock.json is pretty incredible.

Harbormaster completed remote builds in B22296: Diff 38351.Mar 8 2023, 18:07
emack requested changes to this revision.Mar 9 2023, 00:52
emack added a subscriber: emack.

It's failing to start for me with the following exception:

image.png (776×1 px, 196 KB)

This is after npm i as well after arc patching.

This revision now requires changes to proceed.Mar 9 2023, 00:52
bytesofman added a comment.Mar 9 2023, 19:03

Probably needs a storybook upgrade as well to deal with the new dependencies. Will check it out.

bytesofman updated this revision to Diff 38368.Mar 9 2023, 19:14

Upgrading webpack and storybook

Harbormaster completed remote builds in B22308: Diff 38368.Mar 9 2023, 19:16
emack accepted this revision.Mar 9 2023, 22:39

yup the webpack and storybook upgrades fixed it.

This revision is now accepted and ready to land.Mar 9 2023, 22:39
Closed by commit rABCe43c035c8780: [cashtab-componets] npm module maintenance (authored by bytesofman). · Explain WhyMar 13 2023, 17:20
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCe43c035c8780: [cashtab-componets] npm module maintenance.

Revision Contents
Changeset List

PathSize
web/
cashtab-components/
3940 lines
20 lines

Diff 38368

View Options

web/cashtab-components/package-lock.json

Loading...
View Options

web/cashtab-components/package.json

Loading...