remove cs_main extern declaration from net_processing.h
ClosedPublic
Actions

Authored by PiRK on Mar 14 2023, 09:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC29bba42dc009: remove cs_main extern declaration from net_processing.h

Summary

net_processing.h does not need cs_main since D10890
net_processing.cpp includes validation.h where cs_main is defined.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cs_main

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22429
Build 44484: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 44483: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 14 2023, 09:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2023, 09:32

PiRK requested review of this revision.Mar 14 2023, 09:32

Harbormaster completed remote builds in B22429: Diff 38538.Mar 14 2023, 09:49

Fabien accepted this revision.Mar 14 2023, 11:06

This revision is now accepted and ready to land.Mar 14 2023, 11:06

Closed by commit rABC29bba42dc009: remove cs_main extern declaration from net_processing.h (authored by PiRK). · Explain WhyMar 14 2023, 11:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC29bba42dc009: remove cs_main extern declaration from net_processing.h.

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

2 lines

Diff 38538

View Options

remove cs_main extern declaration from net_processing.hClosedPublicActions