scripted-diff: rename NetPermissionFlags enumerators
Summary:
- drop redundant PF_ permission flags prefixes
- drop ALL_CAPS naming per https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-caps
- rename IsImplicit to Implicit
- update noban documentation in net_processing.cpp
-BEGIN VERIFY SCRIPT-
s() { git grep -l "$1" src | xargs sed -i "s/$1/$2/g"; }
s 'PF_NONE' 'None'
s 'PF_BLOOMFILTER' 'BloomFilter'
s 'PF_RELAY' 'Relay'
s 'PF_FORCERELAY' 'ForceRelay'
s 'PF_DOWNLOAD' 'Download'
s 'PF_NOBAN' 'NoBan'
s 'PF_MEMPOOL' 'Mempool'
s 'PF_ADDR' 'Addr'
s 'PF_ISIMPLICIT' 'Implicit'
s 'PF_ALL' 'All'
s 'PF_BYPASS_PROOF_REQUEST_LIMITS' 'BypassProofRequestLimits'
s() { git grep -l "$1" src/net_processing.cpp | xargs sed -i "s/$1/$2/g"; }
s 'the noban permission' 'NetPermissionFlags::NoBan permission'
s 'the NOBAN permission flag' 'NetPermissionFlags::NoBan permission'
s 'noban permission' 'NetPermissionFlags::NoBan permission'
arc lint
-END VERIFY SCRIPT-This is a partial backport of core#21506
https://github.com/bitcoin/bitcoin/pull/21506/commits/a95540cf435029f06e56749802d71315ca76b0dd
https://github.com/bitcoin/bitcoin/pull/21506/commits/7075f604e8d0b21b2255fa57e20cd365dc10a288
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Depends on D13325
Test Plan: ninja all check-all bitcoin-fuzzers
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D13324