Paths

Table of Contentst

Differential D13342

p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)`
ClosedPublic
Actions

Authored by PiRK on Mar 15 2023, 10:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7a47f32cce54: p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)`

Summary

introduce constant variables score_before and score_after in order to improve readability
deduplicate calls to LogPrint(), eliminates else-branch
update BAN to DISCOURAGE in logs (missed in D6506)

This is a backport of core#22495

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr22495

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22464
Build 44553: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 44552: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 15 2023, 10:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2023, 10:32

PiRK requested review of this revision.Mar 15 2023, 10:32

teamcity edited the summary of this revision. (Show Details)Mar 15 2023, 10:32

Harbormaster completed remote builds in B22464: Diff 38595.Mar 15 2023, 10:52

Fabien accepted this revision.Mar 15 2023, 13:40

This revision is now accepted and ready to land.Mar 15 2023, 13:40

Closed by commit rABC7a47f32cce54: p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)` (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyMar 16 2023, 07:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7a47f32cce54: p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)`.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

22 lines

test/

functional/

abc_p2p_avalanche_peer_discovery.py

3 lines

Diff 38595

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_peer_discovery.py

Loading...