Differential D13395

Let BlockAssembler::AddToBlock take a mempool entry
ClosedPublic
Actions

Authored by Fabien on Mar 20 2023, 19:43.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC11ff26ad8fff: Let BlockAssembler::AddToBlock take a mempool entry

Summary

This makes it easier to reason about and will simplify the follow up diffs.
There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

miner_addtx_entry

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22556
Build 44732: Build Diff	build-without-wallet · build-diff · build-clang · lint-circular-dependencies · build-debug · build-clang-tidy
Build 44731: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 20 2023, 19:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2023, 19:43

Fabien requested review of this revision.Mar 20 2023, 19:43

Harbormaster completed remote builds in B22556: Diff 38718.Mar 20 2023, 19:57

PiRK accepted this revision.Mar 21 2023, 06:53

This revision is now accepted and ready to land.Mar 21 2023, 06:53

Closed by commit rABC11ff26ad8fff: Let BlockAssembler::AddToBlock take a mempool entry (authored by Fabien). · Explain WhyMar 21 2023, 08:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC11ff26ad8fff: Let BlockAssembler::AddToBlock take a mempool entry.

Revision Contents
Changeset List

Path

Size

src/

node/

miner.h

2 lines

miner.cpp

18 lines

Diff 38718

View Options

src/node/miner.h