Page MenuHomePhabricator
Differential D13474

[ecashaddrjs] Use ecash: addresses in unit tests
ClosedPublic
Actions

Authored by bytesofman on Mar 27 2023, 12:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1570a7526299: [ecashaddrjs] Use ecash: addresses in unit tests
Summary

T3039

Convert address formats from bitcoincash: to ecash: for unit tests of cashaddr.js

Note: One bitcoincash: adddress remains, as it was manually constructed to have an improper version byte. updated to ecash: version

Test Plan

npm test and still pass

Diff Detail

Repository
rABC Bitcoin ABC
Branch
path-to-publish-ecashaddrjs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22721
Build 45062: Build Diff
Build 45061: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 27 2023, 12:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2023, 12:52
bytesofman requested review of this revision.Mar 27 2023, 12:52
Harbormaster completed remote builds in B22721: Diff 38917.Mar 27 2023, 12:52
bytesofman added a child revision: D13475: [ecashaddrjs] Support decoding prefixless addresses if checksum is correct.Mar 27 2023, 12:56
Fabien requested changes to this revision.Mar 27 2023, 15:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecashaddrjs/test/cashaddr.js
137

ecash:zpm2qsznhks23z7629mms6s4cwef74vcwv6ddac6re

This revision now requires changes to proceed.Mar 27 2023, 15:17
bytesofman edited the summary of this revision. (Show Details)Mar 27 2023, 15:39
bytesofman updated this revision to Diff 38925.Mar 27 2023, 15:39

replacing version byte error test with ecash: address

Harbormaster completed remote builds in B22728: Diff 38925.Mar 27 2023, 15:39
Fabien accepted this revision.Mar 27 2023, 16:11
This revision is now accepted and ready to land.Mar 27 2023, 16:11
Closed by commit rABC1570a7526299: [ecashaddrjs] Use ecash: addresses in unit tests (authored by bytesofman). · Explain WhyMar 27 2023, 16:23
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1570a7526299: [ecashaddrjs] Use ecash: addresses in unit tests.

Revision Contents
Changeset List

PathSize
web/
ecashaddrjs/
test/
50 lines

Diff 38917

View Options

web/ecashaddrjs/test/cashaddr.js

Loading...