Page MenuHomePhabricator
Differential D13483

Use block policy state instead of parked state to determine if a policy was violated
ClosedPublic
Actions

Authored by sdulfari on Mar 27 2023, 21:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC39373b71509c: Use block policy state instead of parked state to determine if a policy was…
Summary

Bubble the block policy state up through ConnectTip so the caller can more
robustly short circuit when a block policy fails (and not just assume that
a policy failed because a block was parked).

Depends on D13482

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

sdulfari created this revision.Mar 27 2023, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2023, 21:14
sdulfari requested review of this revision.Mar 27 2023, 21:14
Harbormaster completed remote builds in B22742: Diff 38948.Mar 27 2023, 21:29
PiRK accepted this revision.Mar 28 2023, 09:27
This revision is now accepted and ready to land.Mar 28 2023, 09:27
Fabien added a subscriber: Fabien.Mar 28 2023, 12:35
Fabien added inline comments.
src/validation.cpp
2733

See question in D13482: does std::all_of stop on first false condition (and is that guaranteed) ? Otherwise the design is wrong

Closed by commit rABC39373b71509c: Use block policy state instead of parked state to determine if a policy was… (authored by sdulfari). · Explain WhyApr 3 2023, 18:24
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC39373b71509c: Use block policy state instead of parked state to determine if a policy was….

Revision Contents
Changeset List

PathSize
src/
2 lines
9 lines

Diff 38948

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...