Page MenuHomePhabricator
Differential D13519

[alias-server] deprecate return of pending alias txs from getValidAliasRegistrations function
ClosedPublic
Actions

Authored by bytesofman on Mar 31 2023, 12:15.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb1160b1d87f0: [alias-server] deprecate return of pending alias txs from…
Summary

T3060

Depends on D13518

It doesn't make sense to get pending (i.e. unconfirmed but otherwise valid) alias registrations in a function that will be called when new blocks are found. Pending alias txs will be handled separately.

Test Plan

npm test
node index.js and app works as normal

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22867
Build 45354: Build Diffalias-server-tests
Build 45353: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 31 2023, 12:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2023, 12:15
bytesofman requested review of this revision.Mar 31 2023, 12:15
Harbormaster completed remote builds in B22867: Diff 39097.Mar 31 2023, 12:16
bytesofman added a child revision: D13520: [alias-server] Patch import refs in generateMocks.js.Mar 31 2023, 12:18
bytesofman edited the test plan for this revision. (Show Details)Mar 31 2023, 12:18
emack requested changes to this revision.Mar 31 2023, 12:49
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/scripts/generateMocks.js
9

this should be require('../src/alias');, otherwise the following error is throw when running npm run mocks

image.png (419×891 px, 80 KB)

This revision now requires changes to proceed.Mar 31 2023, 12:49
emack accepted this revision.Mar 31 2023, 12:54

just saw this issue is rectified in D13520

This revision is now accepted and ready to land.Mar 31 2023, 12:54
Closed by commit rABCb1160b1d87f0: [alias-server] deprecate return of pending alias txs from… (authored by bytesofman). · Explain WhyMar 31 2023, 13:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb1160b1d87f0: [alias-server] deprecate return of pending alias txs from….

Revision Contents
Changeset List

PathSize
web/
alias-server/
scripts/
21 lines
src/
13 lines
11 lines
test/
20 lines

Diff 39097

View Options

web/alias-server/scripts/generateMocks.js

Loading...
View Options

web/alias-server/src/alias.js

Loading...
View Options

web/alias-server/src/websocket.js

Loading...
View Options

web/alias-server/test/aliasTests.js

Loading...