Paths

Table of Contentst

Differential D13574

[Chronik] Add `/script/:type/:payload/unconfirmed-txs`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 5 2023, 08:45.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCbc6b5a773caa: [Chronik] Add `/script/:type/:payload/unconfirmed-txs`

Summary

This is the equivalent of /script/:type/:payload/confirmed-txs but only for mempool txs. We (currently) always return all txs of a script without pagination, as querying from the mempool (which is in RAM) will always be fast.

We still return TxHistoryPage, in case we might need pagination in the future, and having it return the same type as the other endpoints is nice for users of the API.

Depends on D13567.

Test Plan

ninja check-crates && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-script-unconfirmed-txs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22975
Build 45570: Build Diff	build-clang-tidy · build-diff · build-without-wallet · build-debug · build-clang · build-chronik
Build 45569: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 5 2023, 08:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2023, 08:45

tobias_ruck requested review of this revision.Apr 5 2023, 08:45

Harbormaster completed remote builds in B22975: Diff 39258.Apr 5 2023, 09:01

Fabien accepted this revision.Apr 5 2023, 09:33

This revision is now accepted and ready to land.Apr 5 2023, 09:33

Also test if txs are removed from the script in the mempool when there's a conflict tx mined

Harbormaster completed remote builds in B22979: Diff 39262.Apr 5 2023, 10:04

Closed by commit rABCbc6b5a773caa: [Chronik] Add `/script/:type/:payload/unconfirmed-txs` (authored by tobias_ruck). · Explain WhyApr 5 2023, 10:07

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCbc6b5a773caa: [Chronik] Add `/script/:type/:payload/unconfirmed-txs`.

tobias_ruck mentioned this in D15386: [Chronik] Add `/token-id/...` endpoints.Feb 12 2024, 11:20

Revision Contents
Changeset List

Path

Size

chronik/

chronik-db/

src/

mem/

31 lines

chronik-http/

src/

33 lines

19 lines

chronik-indexer/

src/

4 lines

query/

group_history.rs

48 lines

test/

functional/

chronik_script_unconfirmed_txs.py

206 lines

Diff 39258

chronik/chronik-db/src/mem/mempool.rs

Loading...

chronik/chronik-http/src/handlers.rs

Loading...

chronik/chronik-http/src/server.rs

Loading...

chronik/chronik-indexer/src/indexer.rs

Loading...

chronik/chronik-indexer/src/query/group_history.rs

Loading...

test/functional/chronik_script_unconfirmed_txs.py

Loading...