Paths

Table of Contentst

[Lint] Lint everything, apply some of the patches
ClosedPublic
Actions

Authored by tobias_ruck on Apr 4 2023, 15:57.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABCaa4628e798c3: [Lint] Lint everything, apply some of the patches

Summary

Fixes and auto-fixes after running arc lint --everything. It seems some fixes are malfunctioning, they truncate e.g. test_node.py, which we
ignore.

It also fixes some new lints for Rust introduced by D13556.

Test Plan

Run arc lint --everything
Some false lints (truncate pythong files), but mostly no changes

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Apr 4 2023, 15:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 15:57

tobias_ruck requested review of this revision.Apr 4 2023, 15:57

PiRK accepted this revision.Apr 4 2023, 16:04

This revision is now accepted and ready to land.Apr 4 2023, 16:04

tobias_ruck added a child revision: D13567: [Chronik] Add `/script/:type/:payload/confirmed-txs`.Apr 4 2023, 16:15

Fabien accepted this revision.Apr 4 2023, 16:20

Harbormaster completed remote builds in B22957: Diff 39234.Apr 4 2023, 16:23

Closed by commit rABCaa4628e798c3: [Lint] Lint everything, apply some of the patches (authored by tobias_ruck). · Explain WhyApr 4 2023, 16:26

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCaa4628e798c3: [Lint] Lint everything, apply some of the patches.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-lib/

src/

bridge.rs

2 lines

error.rs

2 lines

src/

crypto/

4 lines

8 lines

28 lines

28 lines

qt/

bitcoingui.cpp

5 lines

test/

checkqueue_tests.cpp

3 lines

dbwrapper_tests.cpp

3 lines

util/

variant.h

4 lines

validation.cpp

22 lines

test/

functional/

abc_p2p_avalanche_policy_minerfund.py

3 lines

Diff 39240

View Options

chronik/chronik-lib/src/bridge.rs

View Options

chronik/chronik-lib/src/error.rs

View Options

src/crypto/ripemd160.cpp

View Options

src/crypto/sha1.cpp

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/util/variant.h

View Options

src/validation.cpp

View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

[Lint] Lint everything, apply some of the patchesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39240

chronik/chronik-lib/src/bridge.rs

chronik/chronik-lib/src/error.rs

src/crypto/ripemd160.cpp

src/crypto/sha1.cpp

src/crypto/sha256_avx2.cpp

src/crypto/sha256_sse41.cpp

src/qt/bitcoingui.cpp

src/test/checkqueue_tests.cpp

src/test/dbwrapper_tests.cpp

src/util/variant.h

src/validation.cpp

test/functional/abc_p2p_avalanche_policy_minerfund.py

[Lint] Lint everything, apply some of the patches
ClosedPublic
Actions

Revision Contents
Changeset List