Paths

Table of Contentst

[Lint] Lint everything, apply some of the patches
aa4628e798c3
Actions

Description

[Lint] Lint everything, apply some of the patches

Summary:
Fixes and auto-fixes after running arc lint --everything. It seems some fixes are malfunctioning, they truncate e.g. test_node.py, which we
ignore.

It also fixes some new lints for Rust introduced by D13556.

Test Plan:

Run arc lint --everything
Some false lints (truncate pythong files), but mostly no changes

Reviewers: Fabien, #bitcoin_abc, PiRK

Reviewed By: Fabien, #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D13565

Details

Provenance

tobias_ruck	Authored on Apr 4 2023, 15:54
tobias_ruck	Pushed on Apr 4 2023, 16:26

Reviewer

Restricted Project

Differential Revision

D13565: [Lint] Lint everything, apply some of the patches

Parents

rABC9e7ee00a415d: [Chronik] Remove `Network` proto enum

Branches

Unknown

Tags

Unknown

Event Timeline

tobias_ruck committed rABCaa4628e798c3: [Lint] Lint everything, apply some of the patches (authored by tobias_ruck).Apr 4 2023, 16:26

tobias_ruck added an edge: D13565: [Lint] Lint everything, apply some of the patches.

Changes (12)

Path

Size

chronik/

chronik-lib/

src/

bridge.rs

error.rs

src/

crypto/

qt/

test/

util/

test/

functional/

abc_p2p_avalanche_policy_minerfund.py

rABCaa4628e798c3

View Options

chronik/chronik-lib/src/bridge.rs

View Options

chronik/chronik-lib/src/error.rs

View Options

src/crypto/ripemd160.cpp

View Options

src/crypto/sha1.cpp

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/util/variant.h

View Options

src/validation.cpp

View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

[Lint] Lint everything, apply some of the patchesaa4628e798c3Actions

Description

Details

Event Timeline

Changes (12)

rABCaa4628e798c3

chronik/chronik-lib/src/bridge.rs

chronik/chronik-lib/src/error.rs

src/crypto/ripemd160.cpp

src/crypto/sha1.cpp

src/crypto/sha256_avx2.cpp

src/crypto/sha256_sse41.cpp

src/qt/bitcoingui.cpp

src/test/checkqueue_tests.cpp

src/test/dbwrapper_tests.cpp

src/util/variant.h

src/validation.cpp

test/functional/abc_p2p_avalanche_policy_minerfund.py

[Lint] Lint everything, apply some of the patches
aa4628e798c3
Actions