Page MenuHomePhabricator

[lint] run python linters on contrib
AbandonedPublic

Authored by PiRK on Apr 6 2023, 06:03.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Run python linter on contrib directory, excluding only gitian_updater which is third-party code.
For mypy exclude also macdeploy, because there are some non-trivial errors that will take more work to be fixed.

For lint-python-encoding, skip a file that has a open(filename, self.mode) false positive. This linter seems a bit too restrictive, but as long as there is only a single false positive it is easiest to just ignore it.

This is a backport of core#20451

Test Plan

arc lint --everything and gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_devtools
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 23027
Build 45674: Build Diffcheck-buildbot
Build 45673: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Apr 6 2023, 06:03

@bot gitian-osx gitian-linux gitian-win

Fabien added inline comments.
.arclint
265 ↗(On Diff #39328)

Any reason to exclude apple-sdk-tools ?

PiRK planned changes to this revision.Apr 6 2023, 08:47

contrib needs more work before activation mypy

run linters on all of contrib/ except gitian-builder (and macdeploy for mypy)

PiRK retitled this revision from [lint] run python linters on contrib/devtools to [lint] run python linters on contrib.Apr 6 2023, 12:28
PiRK edited the summary of this revision. (Show Details)
PiRK planned changes to this revision.Apr 6 2023, 12:32