Page MenuHomePhabricator

[Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly
ClosedPublic

Authored by tobias_ruck on Apr 8 2023, 12:15.

Details

Summary

Encapsulates what we need to query blocks. This allows us to more easily add more data required for serving blocks, e.g. the current avalanche height.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-query-blocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23241
Build 46101: Build Diffbuild-chronik
Build 46100: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Apr 9 2023, 11:31
Fabien added inline comments.
chronik/chronik-indexer/src/query/blocks.rs
38 ↗(On Diff #39425)

I don't think so

This revision now requires changes to proceed.Apr 9 2023, 11:31

fix comment for by_hash_or_height

This revision is now accepted and ready to land.Apr 12 2023, 15:23