Paths

Table of Contentst

Differential D13714

[herald] Clean up code commenting in parse.js
ClosedPublic
Actions

Authored by bytesofman on Apr 14 2023, 03:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbc699c908936: [herald] Clean up code commenting in parse.js

Summary

T2972

Depends on D13713

Clean up out of date comments in parse.js

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tg-function-to-utils

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23306
Build 46231: Build Diff	ecash-herald-tests
Build 46230: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 14 2023, 03:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2023, 03:28

bytesofman requested review of this revision.Apr 14 2023, 03:28

bytesofman edited the summary of this revision. (Show Details)Apr 14 2023, 03:29

bytesofman added a parent revision: D13713: [herald] Move telegram function to telegram.js.

Harbormaster completed remote builds in B23306: Diff 39720.Apr 14 2023, 03:29

bytesofman added a child revision: D13715: [herald] Remove unnecessary flag variable.Apr 14 2023, 03:32

Fabien accepted this revision.Apr 14 2023, 13:23

This revision is now accepted and ready to land.Apr 14 2023, 13:23

Closed by commit rABCbc699c908936: [herald] Clean up code commenting in parse.js (authored by bytesofman). · Explain WhyApr 14 2023, 21:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCbc699c908936: [herald] Clean up code commenting in parse.js.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

20 lines

Diff 39720

View Options

apps/ecash-herald/src/parse.js

[herald] Clean up code commenting in parse.jsClosedPublicActions