Page MenuHomePhabricator

[e.cash] Add hero section content
ClosedPublic

Authored by johnkuney on Apr 26 2023, 20:51.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCd6da51e62e01: [e.cash] Add hero section content
Summary

Adding some content to the top section of homepage

  • Added text and the social links, will do button in seperate diff
Test Plan

Either run the app locally with npm run dev or generate a preview build with @bot preview-e.cash
Inspect content. Should look good and be responsive

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-homepage-toptext
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23503
Build 46625: Build Diff
Build 46624: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/e.cash/components/glitch-text/styles.js
8 ↗(On Diff #39996)

typo

36–74 ↗(On Diff #39996)

lots of hardcoded values is this file

Is there any reason we might want to change these by theme in the future?

If not, fine to keep them this way. Just something to think about.

Where did the values come from? Is this from manual tweaking or are these what we had on the old page?

web/e.cash/pages/index.js
16 ↗(On Diff #39996)

ah, this is why the upercase typo above is ok, it's already capitalized here

Either capitalize it here and don't include a text-transform: uppercase or keep it lowercase here with the text-transform

17 ↗(On Diff #39996)

ditto

web/e.cash/public/images/discord.svg
2 ↗(On Diff #39996)

i dunno what our policy is for svg and adding a newline at the end of the file. Just add one since might as well. we don't like to see this in phab.

web/e.cash/public/images/facebook.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/public/images/github.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/public/images/instagram.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/public/images/linkedin.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/public/images/reddit.svg
9 ↗(On Diff #39996)

ditto

web/e.cash/public/images/twitter.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/public/images/youtube.svg
2 ↗(On Diff #39996)

ditto

web/e.cash/styles/theme.js
23 ↗(On Diff #39996)

what is this change for / what is it doing?

This revision now requires changes to proceed.Apr 26 2023, 21:05

Fix extra lines and css rule

web/e.cash/components/glitch-text/styles.js
36–74 ↗(On Diff #39996)

I dont think we would want to change by theme.

And yeah its not pretty, but yeah just copied from the current site. I can clean up the decimals at least

web/e.cash/styles/theme.js
23 ↗(On Diff #39996)

the blue in the glitch effect was using this color. Changed it to the gray for the stealth theme

remove text transform rule

social links are not visible at widths below 921px

Should be added to the hamburger like the other links unless there is some other plan to display them on mobile devices

This revision now requires changes to proceed.Apr 26 2023, 21:37

change breakpoint for hiding social links

changed the breakpoint for hiding, and links will be visible in the footer eventually and I made an issue to add them to the mobile menu

This revision is now accepted and ready to land.Apr 26 2023, 22:10
This revision was automatically updated to reflect the committed changes.

Tail of the build log:

#7 3.745 
#7 3.745 added 68 packages, and audited 69 packages in 3s
#7 3.745 
#7 3.745 5 packages are looking for funding
#7 3.745   run `npm fund` for details
#7 3.746 
#7 3.746 found 0 vulnerabilities
#7 3.746 npm notice 
#7 3.746 npm notice New major version of npm available! 8.19.4 -> 9.6.5
#7 3.746 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
#7 3.746 npm notice Run `npm install -g npm@9.6.5` to update!
#7 3.746 npm notice 
#7 DONE 6.4s

#8 [4/4] RUN npm run build
#8 sha256:5e1f53a769aa420281dbcb3883c371ef905ff0711be58595092b854a9e807935
#8 0.829 
#8 0.829 > e.cash@0.0.1 build
#8 0.829 > next build
#8 0.829 
#8 1.156 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#8 1.156 This information is used to shape Next.js' roadmap and prioritize features.
#8 1.156 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#8 1.156 https://nextjs.org/telemetry
#8 1.156 
#8 1.243 info  - Linting and checking validity of types...
#8 1.506 info  - Creating an optimized production build...
#8 4.369 info  - Compiled successfully
#8 4.369 info  - Collecting page data...
#8 5.281 info  - Generating static pages (0/3)
#8 5.494 info  - Generating static pages (3/3)
#8 5.595 info  - Finalizing page optimization...
#8 5.598 
#8 5.614 Route (pages)                              Size     First Load JS
#8 5.614 ┌ ○ /                                      10.2 kB          98 kB
#8 5.614 ├   /_app                                  0 B            87.8 kB
#8 5.614 └ ○ /404                                   181 B            88 kB
#8 5.614 + First Load JS shared by all              88.2 kB
#8 5.614   ├ chunks/framework-2c79e2a64abdb08b.js   45.2 kB
#8 5.614   ├ chunks/main-f11614d8aa7ee555.js        26.8 kB
#8 5.614   ├ chunks/pages/_app-b44a903e45187574.js  14.9 kB
#8 5.614   ├ chunks/webpack-d38be8d96a62f950.js     821 B
#8 5.614   └ css/f829764cc9215e81.css               389 B
#8 5.614 
#8 5.614 ○  (Static)  automatically rendered as static HTML (uses no initial props)
#8 5.614 
#8 DONE 6.6s

#9 exporting to image
#9 sha256:e8c613e07b0b7ff33893b694f7759a10d42e180f2b4dc349fb57dc6b71dcab00
#9 exporting layers
#9 exporting layers 1.2s done
#9 writing image sha256:a129b52b341b1a6c712cfdb7f03dfdb2e255139c1829752530f7439c744d6fa4 done
#9 naming to docker.io/library/preview-e.cash-1efb53c8e done
#9 DONE 1.2s
df7630482322ffbb7ec06cb527f8fac98d0b69cee14b6a3130b1f62658917e39
Preview is available at http://51.83.220.60:41412 for the next 60 minutes.
warning: commands will be executed using /bin/sh
job 1 at Thu Apr 27 18:38:00 2023
Build preview-e.cash completed successfully

Tail of the build log:

#7 3.745 
#7 3.745 added 68 packages, and audited 69 packages in 3s
#7 3.745 
#7 3.745 5 packages are looking for funding
#7 3.745   run `npm fund` for details
#7 3.746 
#7 3.746 found 0 vulnerabilities
#7 3.746 npm notice 
#7 3.746 npm notice New major version of npm available! 8.19.4 -> 9.6.5
#7 3.746 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
#7 3.746 npm notice Run `npm install -g npm@9.6.5` to update!
#7 3.746 npm notice 
#7 DONE 5.5s

#8 [4/4] RUN npm run build
#8 sha256:d51e0857ad5b838328793848a64fdeff40f776eba94ca80fff3d7dcece7af3a3
#8 0.770 
#8 0.770 > e.cash@0.0.1 build
#8 0.770 > next build
#8 0.770 
#8 1.095 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#8 1.095 This information is used to shape Next.js' roadmap and prioritize features.
#8 1.095 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#8 1.096 https://nextjs.org/telemetry
#8 1.096 
#8 1.185 info  - Linting and checking validity of types...
#8 1.397 info  - Creating an optimized production build...
#8 4.241 info  - Compiled successfully
#8 4.242 info  - Collecting page data...
#8 5.153 info  - Generating static pages (0/3)
#8 5.365 info  - Generating static pages (3/3)
#8 5.470 info  - Finalizing page optimization...
#8 5.473 
#8 5.488 Route (pages)                              Size     First Load JS
#8 5.488 ┌ ○ /                                      10.2 kB          98 kB
#8 5.488 ├   /_app                                  0 B            87.8 kB
#8 5.488 └ ○ /404                                   181 B            88 kB
#8 5.488 + First Load JS shared by all              88.2 kB
#8 5.488   ├ chunks/framework-2c79e2a64abdb08b.js   45.2 kB
#8 5.488   ├ chunks/main-f11614d8aa7ee555.js        26.8 kB
#8 5.488   ├ chunks/pages/_app-b44a903e45187574.js  14.9 kB
#8 5.488   ├ chunks/webpack-d38be8d96a62f950.js     821 B
#8 5.488   └ css/f829764cc9215e81.css               389 B
#8 5.488 
#8 5.488 ○  (Static)  automatically rendered as static HTML (uses no initial props)
#8 5.488 
#8 DONE 5.9s

#9 exporting to image
#9 sha256:e8c613e07b0b7ff33893b694f7759a10d42e180f2b4dc349fb57dc6b71dcab00
#9 exporting layers
#9 exporting layers 1.2s done
#9 writing image sha256:ae181a0dd9541d457ccf1d9fc25eb9e1944593c862930fb06dd827e68ffbedd1 done
#9 naming to docker.io/library/preview-e.cash-aabe8c2cf done
#9 DONE 1.2s
0a849af03fd136405778c145e6d173b42a05d2a2a501bc77e0b11013bc64c429
Preview is available at http://51.178.130.230:41926 for the next 60 minutes.
warning: commands will be executed using /bin/sh
job 6 at Fri Apr 28 08:52:00 2023
Build preview-e.cash completed successfully