Page MenuHomePhabricator
Differential D1466

Refactor blockstatus_tests.cpp to avoid deep nesting.
ClosedPublic
Actions

Authored by deadalnix on May 29 2018, 11:33.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting.
rABC2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting.
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
blockstatustestrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2671
Build 3454: Bitcoin ABC Buildbot (legacy)
Build 3453: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 29 2018, 11:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2018, 11:33
teamcity added a subscriber: teamcity.May 29 2018, 11:33

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2671: Diff 4021.May 29 2018, 12:08
teamcity added a comment.May 29 2018, 12:08

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1469: Introduce the concept of parked chain..May 29 2018, 19:23
jasonbcox requested changes to this revision.Jun 5 2018, 22:51
jasonbcox added a subscriber: jasonbcox.

One nit that was confusing to read. Looks good otherwise.

src/test/blockstatus_tests.cpp
81

CheckHaveAndUndo -> CheckDataAndUndo

This revision now requires changes to proceed.Jun 5 2018, 22:51
deadalnix updated this revision to Diff 4069.Jun 5 2018, 23:44

Update naming as per request

teamcity added a comment.Jun 5 2018, 23:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 6 2018, 00:18

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2705: Diff 4069.Jun 6 2018, 00:18
jasonbcox accepted this revision.Jun 7 2018, 22:32
This revision is now accepted and ready to land.Jun 7 2018, 22:32
Closed by commit rABC2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting. (authored by deadalnix). · Explain WhyJun 8 2018, 14:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
123 lines

Diff 4021

View Options

src/test/blockstatus_tests.cpp

Loading...