Differential D13894

[lint] replace autopep8 with black (contrib/buildbot)
ClosedPublic
Actions

Authored by PiRK on May 12 2023, 19:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC963fd2f435d3: [lint] replace autopep8 with black (contrib/buildbot)

Summary

This concludes the sunsetting of autopep8 in favor of black, for a much more deterministic formatting (less dependant on the input format).

Depends on D13892 and D13893

Test Plan

invoke the buildbot

Diff Detail

Repository

rABC Bitcoin ABC

Branch

autopep8_to_black

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23704
Build 47022: Build Diff	check-buildbot
Build 47021: arc lint + arc unit

Event Timeline

PiRK created this revision.May 12 2023, 19:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2023, 19:23

Harbormaster completed remote builds in B23704: Diff 40295.May 12 2023, 19:25

@bot build-linux64

teamcity awarded a token.May 12 2023, 19:48

@bot preview e.cash

teamcity updated a token.May 12 2023, 19:49

PiRK published this revision for review.May 12 2023, 19:50

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

@ bot preview e.cash

I guess it worked, it failed on the typo (another one I introduced deliberately to not trigger the bot)

Fabien accepted this revision.May 12 2023, 19:54

This revision is now accepted and ready to land.May 12 2023, 19:54

Closed by commit rABC963fd2f435d3: [lint] replace autopep8 with black (contrib/buildbot) (authored by PiRK). · Explain WhyMay 13 2023, 06:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC963fd2f435d3: [lint] replace autopep8 with black (contrib/buildbot).

PiRK mentioned this in D13895: [lint] remove references to autopep8.May 13 2023, 06:34

PiRK mentioned this in rABC08465cd80b35: [lint] remove references to autopep8.May 15 2023, 07:14

Revision Contents
Changeset List

Path

Size

.arclint

13 lines

arcanist/

__phutil_library_map__.php

linter/

AutoPEP8Linter.php

contrib/

buildbot/

abcbot.py

36 lines

build.py

11 lines

cirrus.py

44 lines

phabricator_wrapper.py

353 lines

671 lines

29 lines

25 lines

232 lines

test/

abcbot_fixture.py

24 lines

mocks/

1 line

14 lines

26 lines

63 lines

10 lines

test_endpoint_backportcheck.py

279 lines

test_endpoint_build.py

108 lines

test_endpoint_buildDiff.py

150 lines

test_endpoint_getCurrentUser.py

4 lines

test_endpoint_land.py

98 lines

test_endpoint_status.py

1916 lines

test_endpoint_triggerCI.py

307 lines

test_persist_database.py

54 lines

323 lines

68 lines

1057 lines

106 lines

29 lines

Diff 40295

View Options

.arclint

View Options

arcanist/__phutil_library_map__.php

View Options

arcanist/linter/AutoPEP8Linter.php

View Options

contrib/buildbot/abcbot.py

View Options

contrib/buildbot/build.py

View Options

contrib/buildbot/cirrus.py

View Options

contrib/buildbot/phabricator_wrapper.py

View Options

contrib/buildbot/server.py

View Options

contrib/buildbot/shieldio.py

View Options

contrib/buildbot/slackbot.py

View Options

contrib/buildbot/teamcity_wrapper.py

View Options

contrib/buildbot/test/abcbot_fixture.py

View Options

contrib/buildbot/test/mocks/fixture.py

View Options

contrib/buildbot/test/mocks/phabricator.py

View Options

contrib/buildbot/test/mocks/slackbot.py

View Options

contrib/buildbot/test/mocks/teamcity.py

View Options

contrib/buildbot/test/test_build.py

View Options

contrib/buildbot/test/test_endpoint_backportcheck.py

View Options

contrib/buildbot/test/test_endpoint_build.py

View Options

contrib/buildbot/test/test_endpoint_buildDiff.py

View Options

contrib/buildbot/test/test_endpoint_getCurrentUser.py

View Options

contrib/buildbot/test/test_endpoint_land.py

View Options

contrib/buildbot/test/test_endpoint_status.py

View Options

contrib/buildbot/test/test_endpoint_triggerCI.py

View Options

contrib/buildbot/test/test_persist_database.py

View Options

contrib/buildbot/test/test_phabricator.py

View Options

contrib/buildbot/test/test_slackbot.py

View Options

contrib/buildbot/test/test_teamcity.py

View Options

contrib/buildbot/test/test_testutil.py

View Options

contrib/buildbot/testutil.py

[lint] replace autopep8 with black (contrib/buildbot)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40295

.arclint

arcanist/__phutil_library_map__.php

arcanist/linter/AutoPEP8Linter.php

contrib/buildbot/abcbot.py

contrib/buildbot/build.py

contrib/buildbot/cirrus.py

contrib/buildbot/phabricator_wrapper.py

contrib/buildbot/server.py

contrib/buildbot/shieldio.py

contrib/buildbot/slackbot.py

contrib/buildbot/teamcity_wrapper.py

contrib/buildbot/test/abcbot_fixture.py

contrib/buildbot/test/mocks/fixture.py

contrib/buildbot/test/mocks/phabricator.py

contrib/buildbot/test/mocks/slackbot.py

contrib/buildbot/test/mocks/teamcity.py

contrib/buildbot/test/test_build.py

contrib/buildbot/test/test_endpoint_backportcheck.py

contrib/buildbot/test/test_endpoint_build.py

contrib/buildbot/test/test_endpoint_buildDiff.py

contrib/buildbot/test/test_endpoint_getCurrentUser.py

contrib/buildbot/test/test_endpoint_land.py

contrib/buildbot/test/test_endpoint_status.py

contrib/buildbot/test/test_endpoint_triggerCI.py

contrib/buildbot/test/test_persist_database.py

contrib/buildbot/test/test_phabricator.py

contrib/buildbot/test/test_slackbot.py

contrib/buildbot/test/test_teamcity.py

contrib/buildbot/test/test_testutil.py

contrib/buildbot/testutil.py

[lint] replace autopep8 with black (contrib/buildbot)
ClosedPublic
Actions

Revision Contents
Changeset List