Paths

Table of Contentst

Differential D13912

index: Avoid async shutdown on init error
ClosedPublic
Actions

Authored by PiRK on May 17 2023, 14:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC04c0b1b85da8: index: Avoid async shutdown on init error

Summary

An async shutdown during init is confusing when a simple boolean return value can be used for a synchronous shutdown.

This is a backport of core#21796

Depends on D13911

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23730
Build 47071: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 47070: arc lint + arc unit

Event Timeline

PiRK created this revision.May 17 2023, 14:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2023, 14:40

PiRK requested review of this revision.May 17 2023, 14:40

teamcity edited the summary of this revision. (Show Details)May 17 2023, 14:40

Harbormaster completed remote builds in B23730: Diff 40340.May 17 2023, 15:08

PiRK edited the summary of this revision. (Show Details)May 17 2023, 16:16

PiRK added a parent revision: D13911: index: Improve robustness of coinstatsindex at restart.

PiRK added a child revision: D13913: index: Commit DB_MUHASH and DB_BEST_BLOCK to disk together.May 17 2023, 16:16

Fabien accepted this revision.May 18 2023, 05:45

This revision is now accepted and ready to land.May 18 2023, 05:45

Closed by commit rABC04c0b1b85da8: index: Avoid async shutdown on init error (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMay 18 2023, 07:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC04c0b1b85da8: index: Avoid async shutdown on init error.

Revision Contents
Changeset List

Path

Size

src/

index/

base.h

4 lines

base.cpp

17 lines

init.cpp

13 lines

test/

blockfilter_index_tests.cpp

2 lines

coinstatsindex_tests.cpp

2 lines

txindex_tests.cpp

2 lines

test/

functional/

feature_blockfilterindex_prune.py

19 lines

Diff 40340

View Options

src/index/base.h

View Options

src/index/base.cpp

View Options

src/init.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/coinstatsindex_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

test/functional/feature_blockfilterindex_prune.py

index: Avoid async shutdown on init errorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40340

src/index/base.h

src/index/base.cpp

src/init.cpp

src/test/blockfilter_index_tests.cpp

src/test/coinstatsindex_tests.cpp

src/test/txindex_tests.cpp

test/functional/feature_blockfilterindex_prune.py

index: Avoid async shutdown on init error
ClosedPublic
Actions

Revision Contents
Changeset List