Add BCLog::NET category to disconnect ban message
ClosedPublic
Actions

Authored by schancel on May 30 2018, 18:04.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING3951fbe93e0c: Add BCLog::NET category to disconnect ban message
rABC3951fbe93e0c: Add BCLog::NET category to disconnect ban message

Summary

Continuous reconnecting currently causes banned nodes to spam logs and fill them up with excessive amounts of data. This commit makes such messages goto the NET logging category, which is non-default. This should remove the DoS vector unless individuals are explicitly interested in such messages.

Test Plan

NA

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove-ban-spam

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2684
Build 3480: Bitcoin ABC Buildbot (legacy)
Build 3479: arc lint + arc unit

Event Timeline

schancel created this revision.May 30 2018, 18:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2018, 18:04

Add net category to banning log

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

schancel retitled this revision from Remove disconnect ban message to remove DoS vector to Add BCLog::NET category to disconnect ban message.May 30 2018, 18:06

schancel edited the summary of this revision. (Show Details)

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.May 30 2018, 18:20

This revision is now accepted and ready to land.May 30 2018, 18:20

deadalnix accepted this revision.May 30 2018, 18:32

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2684: Diff 4037.May 30 2018, 18:39

Harbormaster completed remote builds in B2685: Diff 4038.May 30 2018, 18:41

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Closed by commit rABC3951fbe93e0c: Add BCLog::NET category to disconnect ban message (authored by schancel). · Explain WhyMay 31 2018, 01:36

This revision was automatically updated to reflect the committed changes.