Page MenuHomePhabricator
Differential D13954

lint: don't forget to lint .bash files
ClosedPublic
Actions

Authored by PiRK on May 30 2023, 09:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC30b67c5adc94: lint: don't forget to lint .bash files
Summary

This is a backport of core#23506

Note: I also excluded some animation files from json linters to make arc lint --everything usable.

Test Plan

Add a shellcheck violation in a bash file and run arc lint

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_bash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23835
Build 47280: Build Diff
Build 47279: arc lint + arc unit

Event Timeline

PiRK created this revision.May 30 2023, 09:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2023, 09:17
PiRK requested review of this revision.May 30 2023, 09:17
Harbormaster completed remote builds in B23829: Diff 40485.May 30 2023, 09:17
teamcity edited the summary of this revision. (Show Details)May 30 2023, 09:17
PiRK planned changes to this revision.May 30 2023, 09:17

I also need to run arc lint --everything

PiRK edited the test plan for this revision. (Show Details)May 30 2023, 09:18
PiRK edited the test plan for this revision. (Show Details)
PiRK edited the summary of this revision. (Show Details)May 30 2023, 11:39
PiRK updated this revision to Diff 40486.May 30 2023, 11:40
PiRK edited the summary of this revision. (Show Details)

fix two files and exclude some animation files from json linters

Harbormaster completed remote builds in B23830: Diff 40486.May 30 2023, 11:56
Fabien requested changes to this revision.May 30 2023, 13:29
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoingui.cpp
1250 ↗(On Diff #40486)

That's unrelated

This revision now requires changes to proceed.May 30 2023, 13:29
PiRK updated this revision to Diff 40493.May 30 2023, 13:31

revert accidental changes to bitcoingui.cpp

Harbormaster completed remote builds in B23835: Diff 40493.May 30 2023, 13:31
PiRK edited the summary of this revision. (Show Details)May 30 2023, 13:34
Fabien accepted this revision.May 30 2023, 18:27
This revision is now accepted and ready to land.May 30 2023, 18:27
Closed by commit rABC30b67c5adc94: lint: don't forget to lint .bash files (authored by PiRK). · Explain WhyMay 31 2023, 06:41
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC30b67c5adc94: lint: don't forget to lint .bash files.

Revision Contents
Changeset List

PathSize
12 lines
contrib/
shell/
2 lines
2 lines

Diff 40493

View Options

.arclint

Loading...
View Options

contrib/shell/git-utils.bash

Loading...
View Options

contrib/shell/realpath.bash

Loading...