These functions were developed for correctly parsing the latest alias spec. On completion, realized need basically the same thing to continue progress on ecash-herald. Should be a library.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC20c41a4f309d: [ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- opreturn-parsing-lib
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23922 Build 47454: Build Diff Build 47453: arc lint + arc unit
Event Timeline
Comment Actions
Wouldn't be more sensible to make a script parsing/decoding library (even if not feature complete for now), rather than specializing in OP_RETURN decoding ?
E.g. you probably need to differentiate between p2pkh and p2sh for the herald, that could be a good fit for a script library as well.
| modules/ecash-script/.eslintrc.js | ||
|---|---|---|
| 28 ↗ | (On Diff #40615) | No blocker for now, but could this be imported from some common location, maybe using a regex ? There are 2 issues with this:
|
| modules/ecash-script/README.md | ||
| 7 ↗ | (On Diff #40615) | |
| modules/ecash-script/constants/op_return.js | ||
| 6 ↗ | (On Diff #40615) | That's wrong, consume doesn't care about the opcodes |