Page MenuHomePhabricator
Differential D14054

[ecash-herald] Parse SwAP txs
ClosedPublic
Actions

Authored by bytesofman on Jun 13 2023, 21:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC86f227c75c40: [ecash-herald] Parse SwAP txs
Summary

T3060

Parse SWaP txs

Handles some observed inconsistencies between spec and recent network txs (active apps appear to use ASCII for encoding / decoding sats). Stub parsing for uncommon methods, can be expanded as these txs are observed.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-support-swap
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24029
Build 47668: Build Diffecash-herald-tests
Build 47667: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 13 2023, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2023, 21:13
bytesofman requested review of this revision.Jun 13 2023, 21:13
Harbormaster completed remote builds in B24028: Diff 40773.Jun 13 2023, 21:14
bytesofman updated this revision to Diff 40774.Jun 13 2023, 21:22

Better comments, unit test for malformed swap

Harbormaster completed remote builds in B24029: Diff 40774.Jun 13 2023, 21:23
Fabien accepted this revision.Jun 14 2023, 13:06
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/parse.js
378
This revision is now accepted and ready to land.Jun 14 2023, 13:06
Closed by commit rABC86f227c75c40: [ecash-herald] Parse SwAP txs (authored by bytesofman). · Explain WhyJun 14 2023, 13:14
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC86f227c75c40: [ecash-herald] Parse SwAP txs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
constants/
1 line
src/
285 lines
test/
mocks/
177 lines

Diff 40774

View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...